refactor socket tests to use super test

Author: trescenzi

package-lock.json

@@ -76,7 +76,6 @@
     "mocha": "^5.2.0",
     "mocha-sinon": "^2.0.0",
     "nyc": "^12.0.2",
-    "request": "^2.88.0",
     "rimraf": "^2.6.2",
     "should": "^13.2.0",
     "sinon": "^6.1.5",

package.json

@@ -1,34 +1,31 @@
 'use strict';
 
 const assert = require('assert');
-const request = require('request');
+const request = require('supertest');
 const config = require('./fixtures/simple-config/webpack.config');
 const helper = require('./helper');
 
-const requestSucceeds = done => (err, res) => {
-  if (err) {
-    done(err);
-  }
-
-  assert.equal(res.statusCode, 200);
-  done();
-};
-
 describe('socket options', () => {
   let server;
+  let req;
 
-  afterEach(helper.close);
+  afterEach((done) => {
+    helper.close(done)
+    req = null;
+    server = null;
+  });
   describe('default behavior', () => {
     beforeEach((done) => {
       server = helper.start(config, {}, done);
+      req = request('http://localhost:8080');
     });
 
     it('defaults to a path', () => {
       assert.ok(server.sockPath.match(/\/[a-z0-9\-/]+[^/]$/));
     });
 
     it('responds with a 200', (done) => {
-      request('http://localhost:8080/sockjs-node', requestSucceeds(done));
+      req.get('/sockjs-node').expect(200, done);
     });
   });
 
@@ -38,14 +35,16 @@ describe('socket options', () => {
       server = helper.start(config, {
         sockPath: '/foo/test/bar/'
       }, done);
+      req = request('http://localhost:8080');
     });
 
     it('sets the sock path correctly and strips leading and trailing /s', () => {
       assert.equal(server.sockPath, path);
     });
 
+    
     it('responds with a 200 second', (done) => {
-      request(`http://localhost:8080${path}`, requestSucceeds(done));
+      req.get(path).expect(200, done);
     });
   });
 });