chore: enable reportUnusedDisableDirectives for eslint (#4085)

Author: snitin315

.eslintrc.js

@@ -7,6 +7,7 @@ module.exports = {
     sourceType: "script",
     ecmaVersion: 2018,
   },
+  reportUnusedDisableDirectives: true,
   env: {
     node: true,
     es6: true,

client-src/socket.js

@@ -6,10 +6,9 @@ import { log } from "./utils/log.js";
 // this WebsocketClient is here as a default fallback, in case the client is not injected
 /* eslint-disable camelcase */
 const Client =
-  // eslint-disable-next-line camelcase, no-nested-ternary
+  // eslint-disable-next-line no-nested-ternary
   typeof __webpack_dev_server_client__ !== "undefined"
-    ? // eslint-disable-next-line camelcase
-      typeof __webpack_dev_server_client__.default !== "undefined"
+    ? typeof __webpack_dev_server_client__.default !== "undefined"
       ? __webpack_dev_server_client__.default
       : __webpack_dev_server_client__
     : WebSocketClient;
@@ -39,7 +38,7 @@ const socket = function initSocket(url, handlers, reconnect) {
     if (retries < maxRetries) {
       // Exponentially increase timeout to reconnect.
       // Respectfully copied from the package `got`.
-      // eslint-disable-next-line no-mixed-operators, no-restricted-properties
+      // eslint-disable-next-line no-restricted-properties
       const retryInMs = 1000 * Math.pow(2, retries) + Math.random() * 100;
 
       retries += 1;

examples/general/proxy-hot-reload/webpack.config.js

@@ -27,7 +27,7 @@ fs.watch("./proxy-config.js", () => {
       };
     }
   } catch (e) {
-    // eslint-disable-line
+    // ignore
   }
 });
 

lib/Server.js

@@ -1161,7 +1161,6 @@ class Server {
           );
         } else {
           try {
-            // eslint-disable-next-line import/no-dynamic-require
             ClientImplementation = require.resolve(clientTransport);
           } catch (e) {
             clientImplementationFound = false;
@@ -1308,7 +1307,6 @@ class Server {
       signals.forEach((signal) => {
         const listener = () => {
           if (needForceShutdown) {
-            // eslint-disable-next-line no-process-exit
             process.exit();
           }
 
@@ -1321,11 +1319,9 @@ class Server {
           this.stopCallback(() => {
             if (typeof this.compiler.close === "function") {
               this.compiler.close(() => {
-                // eslint-disable-next-line no-process-exit
                 process.exit();
               });
             } else {
-              // eslint-disable-next-line no-process-exit
               process.exit();
             }
           });
@@ -1838,7 +1834,6 @@ class Server {
         return open(openTarget, item.options).catch(() => {
           this.logger.warn(
             `Unable to open "${openTarget}" page${
-              // eslint-disable-next-line no-nested-ternary
               item.options.app
                 ? ` in "${item.options.app.name}" app${
                     item.options.app.arguments

lib/servers/SockJSServer.js

@@ -1,8 +1,5 @@
 "use strict";
 
-/* eslint-disable
-  class-methods-use-this
-*/
 const sockjs = require("sockjs");
 const BaseServer = require("./BaseServer");
 

lib/servers/WebsocketServer.js

@@ -1,8 +1,5 @@
 "use strict";
 
-/* eslint-disable
-  class-methods-use-this
-*/
 const WebSocket = require("ws");
 const BaseServer = require("./BaseServer");
 

test/e2e/entry.test.js

@@ -371,7 +371,6 @@ describe("entry", () => {
     });
 
     new webpack.EntryPlugin(compiler.context, entryFirst, {
-      // eslint-disable-next-line no-undefined
       name: "main",
     }).apply(compiler);
 

test/e2e/overlay.test.js

@@ -17,7 +17,6 @@ class ErrorPlugin {
     this.counter = 0;
   }
 
-  // eslint-disable-next-line class-methods-use-this
   apply(compiler) {
     compiler.hooks.thisCompilation.tap(
       "errors-webpack-plugin",
@@ -44,7 +43,6 @@ class WarningPlugin {
     this.counter = 0;
   }
 
-  // eslint-disable-next-line class-methods-use-this
   apply(compiler) {
     compiler.hooks.thisCompilation.tap(
       "warnings-webpack-plugin",

test/e2e/static-directory.test.js

@@ -486,7 +486,6 @@ describe("static.directory option", () => {
     it("Should throw exception (external url)", (done) => {
       expect.assertions(1);
 
-      // eslint-disable-next-line no-unused-vars
       server = testServer.start(
         config,
         {
@@ -547,7 +546,6 @@ describe("static.directory option", () => {
     });
 
     it("Should throw exception (array with absolute url)", (done) => {
-      // eslint-disable-next-line no-unused-vars
       server = testServer.start(
         config,
         {

test/fixtures/custom-client/CustomSockJSClient.js

@@ -1,8 +1,5 @@
 "use strict";
 
-/* eslint-disable
-  no-unused-vars
-*/
 const SockJS = require("sockjs-client/dist/sockjs");
 
 module.exports = class SockJSClient {

test/fixtures/historyapifallback-2-config/foo.js

@@ -1,3 +1,3 @@
 "use strict";
 
-console.log("Hey."); // eslint-disable-line
+console.log("Hey.");

test/fixtures/historyapifallback-3-config/foo.js

@@ -2,4 +2,4 @@
 
 require("./bar.html");
 
-console.log("Hey."); // eslint-disable-line
+console.log("Hey.");

test/fixtures/historyapifallback-config/foo.js

@@ -3,4 +3,4 @@
 require("./index.html");
 require("./bar.html");
 
-console.log("Hey."); // eslint-disable-line
+console.log("Hey.");