revert id caching

Author: SuaYoo

frontend/src/components/ui/data-grid/controllers/rows.ts

@@ -5,6 +5,8 @@ import type { EmptyObject } from "type-fest";
 import type { DataGrid } from "../data-grid";
 import type { GridItem, GridRowId, GridRows } from "../types";
 
+import { cached } from "@/utils/weakCache";
+
 /**
  * Enables removing and adding rows from a grid.
  *
@@ -23,8 +25,6 @@ export class DataGridRowsController implements ReactiveController {
       addRows?: DataGrid["addRows"];
     };
 
-  readonly #rowIds = new Map<GridItem, GridRowId>();
-
   #prevItems?: GridItem[];
 
   public rows: GridRows = new Map<GridRowId, GridItem>();
@@ -55,25 +55,12 @@ export class DataGridRowsController implements ReactiveController {
             item[rowKey as unknown as string] as GridRowId,
             item,
           ])
-        : items.map((item) => [this.getCachedId(item), item]),
+        : items.map(
+            cached((item) => [nanoid(), item], { cacheConstructor: Map }),
+          ),
     );
   }
 
-  /**
-   * Use item reference to get a persistent generated ID.
-   */
-  private getCachedId(item: GridItem): GridRowId {
-    const id = this.#rowIds.get(item);
-
-    if (id) return id;
-
-    const newId = nanoid();
-
-    this.#rowIds.set(item, newId);
-
-    return newId;
-  }
-
   public setItems(items: GridItem[]) {
     if (!this.#prevItems || items !== this.#prevItems) {
       this.setRowsFromItems(items);