Skip to content

[Bug]: Loading indicator doesn't progress #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SuaYoo opened this issue Jan 22, 2025 · 4 comments · Fixed by #398
Closed

[Bug]: Loading indicator doesn't progress #397

SuaYoo opened this issue Jan 22, 2025 · 4 comments · Fixed by #398
Assignees
@SuaYoo @Shrinks99
Labels
bug Something isn't working front end This issue requires front-end development work ui/ux This issue requires UI/UX work

Comments

@SuaYoo
Copy link
Member

SuaYoo commented Jan 22, 2025 •
edited
Loading

ReplayWeb.page Version

v2.2.5

What did you expect to happen? What happened instead?

When loading a large multi-wacz file downloaded from a Browsertrix collection, the progress bar is stuck at 0% before jumping to the fully loaded state. Tested with. ~41 GB file.

Additionally, the "cancel" button doesn't work.

Step-by-step reproduction instructions

  1. Go to https://replayweb.page/
  2. Upload a large multi-wacz file
  3. Wait until progress bar is shown. Observe that it stays at 0% before jumping to loaded.

Additional details

@Shrinks99 mentioned this may only be an issue with WACZ, but not with WARC.

We may want to show the progress bar for WARC, but show an indeterminate loading indicator for WACZ.
@SuaYoo SuaYoo added the bug Something isn't working label Jan 22, 2025
@ikreymer
Copy link
Member

Perhaps switch to a spinner instead of progress bar.

@SuaYoo SuaYoo added ui/ux This issue requires UI/UX work front end This issue requires front-end development work labels Jan 27, 2025
@SuaYoo SuaYoo moved this from Triage to Todo in Webrecorder Projects Jan 27, 2025
@SuaYoo
Copy link
Member Author

SuaYoo commented Jan 27, 2025 •
edited
Loading

@Shrinks99 mind adding some more details here on what we want to do with the UI? Also a wish for me, but maybe the spinner is combined with a skeleton view so the window isn't mostly white screen?

@SuaYoo SuaYoo pinned this issue Jan 27, 2025
@SuaYoo SuaYoo unpinned this issue Jan 27, 2025
@Shrinks99
Copy link
Contributor

Was thinking that we seperate out the loading states for WARCs and WACZs to two different progress indicators, one spinner and one progress bar. The WARC indexing one is still useful!

@SuaYoo SuaYoo self-assigned this Feb 5, 2025
@SuaYoo SuaYoo moved this from Todo to In Design in Webrecorder Projects Feb 5, 2025
@Shrinks99
Copy link
Contributor

For now if you can update this by just removing the progress bar for WACZs and architect it in such a way that it is easy to replace the SVG with an animated one, that would be great! I may get to this now, it may happen later :)

@SuaYoo SuaYoo moved this from In Design to Implementing in Webrecorder Projects Feb 5, 2025
@SuaYoo SuaYoo mentioned this issue Feb 5, 2025
Merged
@SuaYoo SuaYoo moved this from Implementing to In Review in Webrecorder Projects Feb 6, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuaYoo SuaYoo

@Shrinks99 Shrinks99

Labels
bug Something isn't working front end This issue requires front-end development work ui/ux This issue requires UI/UX work
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Loading indicator fixes webrecorder/replayweb.page
3 participants
@ikreymer @SuaYoo @Shrinks99