fix doc

Author: wecharyu

iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java

@@ -1225,7 +1225,6 @@ public void preDropPartitions(org.apache.hadoop.hive.metastore.api.Table hmsTabl
     } catch (IOException e) {
       throw new MetaException(String.format("Error while fetching the partitions due to: %s", e));
     }
-    context.putToProperties(BaseMetaStoreClient.SKIP_DROP_PARTITION, "true");
   }
 
   @Override
@@ -1242,8 +1241,8 @@ public void preDropPartitions(org.apache.hadoop.hive.metastore.api.Table hmsTabl
       preDropPartitions(hmsTable, context, partExprs);
     } else if (partsSpec.isSetNames()) {
       preTruncateTable(hmsTable, context, partsSpec.getNames());
-      context.putToProperties(BaseMetaStoreClient.SKIP_DROP_PARTITION, "true");
     }
+    context.putToProperties(BaseMetaStoreClient.SKIP_DROP_PARTITION, "true");
   }
 
   private static void validatePartitionSpec(SearchArgument sarg, PartitionSpec partitionSpec) {

standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java

@@ -1980,7 +1980,8 @@ boolean dropPartition(String catName, String db_name, String tbl_name, List<Stri
 
   /**
    * Drop partitions based on an expression.
-   * @deprecated Use {@link #dropPartitions(TableName, RequestPartsSpec, PartitionDropOptions, EnvironmentContext)} instead
+   * @deprecated since 4.1.0, will be removed in 5.0.0
+   * use {@link #dropPartitions(TableName, RequestPartsSpec, PartitionDropOptions, EnvironmentContext)} instead.
    * @param dbName database name.
    * @param tblName table name.
    * @param partExprs I don't understand this fully, so can't completely explain it.  The second
@@ -2002,7 +2003,8 @@ List<Partition> dropPartitions(String dbName, String tblName,
 
   /**
    * Drop partitions based on an expression.
-   * @deprecated Use {@link #dropPartitions(TableName, RequestPartsSpec, PartitionDropOptions, EnvironmentContext)} instead
+   * @deprecated since 4.1.0, will be removed in 5.0.0
+   * use {@link #dropPartitions(TableName, RequestPartsSpec, PartitionDropOptions, EnvironmentContext)} instead.
    * @param catName catalog name.
    * @param dbName database name.
    * @param tblName table name.
@@ -2031,7 +2033,8 @@ default List<Partition> dropPartitions(String catName, String dbName, String tbl
 
   /**
    * Drop partitions based on an expression.
-   * @deprecated Use {@link #dropPartitions(TableName, RequestPartsSpec, PartitionDropOptions, EnvironmentContext)} instead
+   * @deprecated since 4.1.0, will be removed in 5.0.0
+   * use {@link #dropPartitions(TableName, RequestPartsSpec, PartitionDropOptions, EnvironmentContext)} instead.
    * @param catName catalog name.
    * @param dbName database name.
    * @param tblName table name.
@@ -2063,7 +2066,8 @@ default List<Partition> dropPartitions(String catName, String dbName, String tbl
 
   /**
    * Generalization of dropPartitions(),
-   * @deprecated Use {@link #dropPartitions(TableName, RequestPartsSpec, PartitionDropOptions, EnvironmentContext)} instead
+   * @deprecated since 4.1.0, will be removed in 5.0.0
+   * use {@link #dropPartitions(TableName, RequestPartsSpec, PartitionDropOptions, EnvironmentContext)} instead.
    * @param dbName Name of the database
    * @param tblName Name of the table
    * @param partExprs Partition-specification
@@ -2081,7 +2085,8 @@ List<Partition> dropPartitions(String dbName, String tblName,
 
   /**
    * Generalization of dropPartitions(),
-   * @deprecated Use {@link #dropPartitions(TableName, RequestPartsSpec, PartitionDropOptions, EnvironmentContext)} instead
+   * @deprecated since 4.1.0, will be removed in 5.0.0
+   * use {@link #dropPartitions(TableName, RequestPartsSpec, PartitionDropOptions, EnvironmentContext)} instead.
    * @param catName catalog name
    * @param dbName Name of the database
    * @param tblName Name of the table
@@ -2099,13 +2104,23 @@ List<Partition> dropPartitions(String catName, String dbName, String tblName,
       throws NoSuchObjectException, MetaException, TException;
 
   /**
-   * @deprecated Use {@link #dropPartitions(TableName, RequestPartsSpec, PartitionDropOptions, EnvironmentContext)} instead
+   * @deprecated since 4.1.0, will be removed in 5.0.0
+   * use {@link #dropPartitions(TableName, RequestPartsSpec, PartitionDropOptions, EnvironmentContext)} instead.
    */
   @Deprecated
   List<Partition> dropPartitions(String catName, String dbName, String tblName,
       List<Pair<Integer, byte[]>> partExprs, PartitionDropOptions options, EnvironmentContext context)
       throws NoSuchObjectException, MetaException, TException;
 
+  /**
+   * Drop partitions based on the request partitions specification.
+   * @param tableName Name of the table.
+   * @param partsSpec Specification of the partitions to drop.
+   * @param options Options for dropping partitions.
+   * @param context Environment context for the operation.
+   * @return List of Partitions dropped.
+   * @throws TException thrift transport error.
+   */
   List<Partition> dropPartitions(TableName tableName,
       RequestPartsSpec partsSpec, PartitionDropOptions options, EnvironmentContext context)
       throws TException;

standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/client/HookEnabledMetaStoreClient.java

@@ -312,21 +312,6 @@ private void dropDatabaseCascadePerDb(DropDatabaseRequest req, List<String> tabl
     }
   }
 
-  @Override
-  public List<Partition> dropPartitions(String catName, String dbName, String tblName,
-      List<Pair<Integer, byte[]>> partExprs, PartitionDropOptions options, EnvironmentContext context)
-      throws TException {
-    Table table = delegate.getTable(catName, dbName, tblName);
-    HiveMetaHook hook = getHook(table);
-    if (hook != null) {
-      if (context == null) {
-        context = new EnvironmentContext();
-      }
-      hook.preDropPartitions(table, context, partExprs);
-    }
-    return delegate.dropPartitions(catName, dbName, tblName, partExprs, options, context);
-  }
-
   @Override
   public List<Partition> dropPartitions(TableName tableName,
       RequestPartsSpec partsSpec, PartitionDropOptions options, EnvironmentContext context)

standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaHook.java

@@ -218,7 +218,8 @@ default void postGetTable(Table table) {
 
   /**
    * Called before dropping the partitions from the table in the metastore during ALTER TABLE DROP PARTITION.
-   * @deprecated Use {@link #preDropPartitions(Table, EnvironmentContext, RequestPartsSpec)} instead.
+   * @deprecated since 4.1.0, will be removed in 5.0.0
+   * use {@link #preDropPartitions(Table, EnvironmentContext, RequestPartsSpec)} instead.
    * @param table table whose partition needs to be dropped
    * @param context context of the  operation
    * @param partExprs List of partition expressions