Skip to content

Commit 05c09b1

Browse files
committed
Disable verify-test-owners.sh and make go vet more obvious
1 parent 1955ed6 commit 05c09b1

File tree

3 files changed

+2
-1
lines changed

3 files changed

+2
-1
lines changed

hack/make-rules/verify.sh

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ EXCLUDED_CHECKS=(
2626
"verify-linkcheck.sh" # runs in separate Jenkins job once per day due to high network usage
2727
"verify-govet.sh" # it has a separate make vet target
2828
"verify-staging-client-go.sh" # TODO: enable the script after 1.5 code freeze
29+
"verify-test-owners.sh" # TODO(rmmh): figure out how to avoid endless conflicts
2930
)
3031

3132
function is-excluded {

hack/make-rules/vet.sh

+1
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,5 @@ if [[ ${#targets[@]} -eq 0 ]]; then
4646
targets=$(go list -e ./... | egrep -v "/(third_party|vendor|staging|clientset_generated)/")
4747
fi
4848

49+
set -x
4950
go vet "${goflags[@]:+${goflags[@]}}" ${targets[@]}

hack/verify-test-owners.sh

-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,5 @@ source "${KUBE_ROOT}/hack/lib/init.sh"
2424
cd "${KUBE_ROOT}"
2525
if ! hack/update_owners.py --check; then
2626
echo 'Run ./hack/update_owners.py to fix it'
27-
exit # TODO(rmmh): fix Github merging to respect .gitattributes
2827
exit 1
2928
fi

0 commit comments

Comments
 (0)