Skip to content

Commit 5ca03d6

Browse files
author
Kubernetes Submit Queue
authored
Merge pull request kubernetes#48653 from cblecker/verify-godep-fix
Automatic merge from submit-queue (batch tested with PRs 47040, 48597, 48608, 48653) Fix godep verify to use godep restore script **What this PR does / why we need it**: A bug was introduced in kubernetes#48615. `hack/verify-godeps.sh` only downloads and compares if godeps have changed, so it wasn't caught on the original PR. However, when it does run (e.g. https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/48630/pull-kubernetes-verify/38350/) it fails because the godep-save script now doesn't permit a compex GOPATH. verify-godeps.sh actually sets one because it restores godeps not using the `hack/godep-restore.sh` script. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /assign @sttts /priority failing-test
2 parents 8c07c9a + 8b3bf13 commit 5ca03d6

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

hack/verify-godeps.sh

+4-8
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ source "${KUBE_ROOT}/hack/lib/init.sh"
4848
readonly branch=${1:-${KUBE_VERIFY_GIT_BRANCH:-master}}
4949
if ! [[ ${KUBE_FORCE_VERIFY_CHECKS:-} =~ ^[yY]$ ]] && \
5050
! kube::util::has_changes_against_upstream_branch "${branch}" 'Godeps/' && \
51-
! kube::util::has_changes_against_upstream_branch "${branch}" 'vendor/'; then
51+
! kube::util::has_changes_against_upstream_branch "${branch}" 'vendor/' && \
52+
! kube::util::has_changes_against_upstream_branch "${branch}" 'hack/'; then
5253
exit 0
5354
fi
5455

@@ -85,13 +86,8 @@ _kubetmp="${_kubetmp}/kubernetes"
8586
export GOPATH="${_tmpdir}"
8687

8788
pushd "${_kubetmp}" 2>&1 > /dev/null
88-
kube::util::ensure_godep_version v79
89-
90-
export GOPATH="${GOPATH}:${_kubetmp}/staging"
91-
# Fill out that nice clean place with the kube godeps
92-
echo "Starting to download all kubernetes godeps. This takes a while"
93-
godep restore
94-
echo "Download finished"
89+
# Restore the Godeps into our temp directory
90+
hack/godep-restore.sh
9591

9692
# Destroy deps in the copy of the kube tree
9793
rm -rf ./Godeps ./vendor

0 commit comments

Comments
 (0)