Fix loss of Conditions during RC/RS conversion.

Author: enisoc

pkg/api/v1/conversion.go

@@ -254,6 +254,15 @@ func Convert_v1_ReplicationControllerStatus_to_extensions_ReplicaSetStatus(in *v
 	out.ReadyReplicas = in.ReadyReplicas
 	out.AvailableReplicas = in.AvailableReplicas
 	out.ObservedGeneration = in.ObservedGeneration
+	for _, cond := range in.Conditions {
+		out.Conditions = append(out.Conditions, extensions.ReplicaSetCondition{
+			Type:               extensions.ReplicaSetConditionType(cond.Type),
+			Status:             api.ConditionStatus(cond.Status),
+			LastTransitionTime: cond.LastTransitionTime,
+			Reason:             cond.Reason,
+			Message:            cond.Message,
+		})
+	}
 	return nil
 }
 
@@ -296,6 +305,15 @@ func Convert_extensions_ReplicaSetStatus_to_v1_ReplicationControllerStatus(in *e
 	out.ReadyReplicas = in.ReadyReplicas
 	out.AvailableReplicas = in.AvailableReplicas
 	out.ObservedGeneration = in.ObservedGeneration
+	for _, cond := range in.Conditions {
+		out.Conditions = append(out.Conditions, v1.ReplicationControllerCondition{
+			Type:               v1.ReplicationControllerConditionType(cond.Type),
+			Status:             v1.ConditionStatus(cond.Status),
+			LastTransitionTime: cond.LastTransitionTime,
+			Reason:             cond.Reason,
+			Message:            cond.Message,
+		})
+	}
 	return nil
 }
 

pkg/api/v1/conversion_test.go

@@ -261,7 +261,15 @@ func TestReplicationControllerConversion(t *testing.T) {
 			ReadyReplicas:        3,
 			AvailableReplicas:    4,
 			ObservedGeneration:   5,
-			Conditions:           []v1.ReplicationControllerCondition{},
+			Conditions: []v1.ReplicationControllerCondition{
+				{
+					Type:               v1.ReplicationControllerReplicaFailure,
+					Status:             v1.ConditionTrue,
+					LastTransitionTime: metav1.NewTime(time.Unix(123456789, 0)),
+					Reason:             "Reason",
+					Message:            "Message",
+				},
+			},
 		},
 	}
 	in = roundTrip(t, in).(*v1.ReplicationController)