Skip to content

Commit c2ddbd2

Browse files
author
Kubernetes Submit Queue
authored
Merge pull request kubernetes#48621 from marun/fed-remove-replicaset-unittest
Automatic merge from submit-queue [Federation] Remove flakey and redundant replicaset unit test The coverage provided by this test duplicates coverage provided in e2e. As well, the test is 'unit' in name only, as evidenced by the dependency on sleep statements to try to coordinate timing between the test and the controller. If low-level coverage of replicaset scheduling is desired, it can be implemented in a more targeted fashion that is not prone to race conditions. Fixes kubernetes#48368 cc: @kubernetes/sig-federation-pr-reviews
2 parents 7201e1c + d6b2ec2 commit c2ddbd2

File tree

2 files changed

+0
-165
lines changed

2 files changed

+0
-165
lines changed

federation/pkg/federation-controller/sync/BUILD

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ go_test(
4545
srcs = [
4646
"controller_test.go",
4747
"deploymentcontroller_test.go",
48-
"replicasetcontroller_test.go",
4948
],
5049
library = ":go_default_library",
5150
tags = ["automanaged"],
@@ -65,8 +64,6 @@ go_test(
6564
"//vendor/k8s.io/apimachinery/pkg/runtime:go_default_library",
6665
"//vendor/k8s.io/apimachinery/pkg/types:go_default_library",
6766
"//vendor/k8s.io/apimachinery/pkg/util/wait:go_default_library",
68-
"//vendor/k8s.io/apimachinery/pkg/watch:go_default_library",
69-
"//vendor/k8s.io/client-go/testing:go_default_library",
7067
],
7168
)
7269

federation/pkg/federation-controller/sync/replicasetcontroller_test.go

Lines changed: 0 additions & 162 deletions
This file was deleted.

0 commit comments

Comments
 (0)