Skip to content

Commit 2e88eb4

Browse files
mlsorensenMarcus Sorensen
mlsorensen
and
Marcus Sorensen
authored
Update mysql-connector version (apache#8753)
Co-authored-by: Marcus Sorensen <[email protected]>
1 parent 24d5c45 commit 2e88eb4

File tree

18 files changed

+51
-45
lines changed

18 files changed

+51
-45
lines changed

‎client/pom.xml

+7-7
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@
6868
<artifactId>jetty-util</artifactId>
6969
</dependency>
7070
<dependency>
71-
<groupId>mysql</groupId>
72-
<artifactId>mysql-connector-java</artifactId>
71+
<groupId>com.mysql</groupId>
72+
<artifactId>mysql-connector-j</artifactId>
7373
</dependency>
7474
<dependency>
7575
<groupId>org.apache.cloudstack</groupId>
@@ -709,8 +709,8 @@
709709
<dependencies>
710710
<!-- specify the dependent jdbc driver here -->
711711
<dependency>
712-
<groupId>mysql</groupId>
713-
<artifactId>mysql-connector-java</artifactId>
712+
<groupId>com.mysql</groupId>
713+
<artifactId>mysql-connector-j</artifactId>
714714
<version>${cs.mysql.version}</version>
715715
</dependency>
716716
<dependency>
@@ -898,8 +898,8 @@
898898
<outputDirectory>${project.build.directory}/pythonlibs</outputDirectory>
899899
</artifactItem>
900900
<artifactItem>
901-
<groupId>mysql</groupId>
902-
<artifactId>mysql-connector-java</artifactId>
901+
<groupId>com.mysql</groupId>
902+
<artifactId>mysql-connector-j</artifactId>
903903
<overWrite>false</overWrite>
904904
<outputDirectory>${project.build.directory}/lib</outputDirectory>
905905
</artifactItem>
@@ -973,7 +973,7 @@
973973
<exclude>org.bouncycastle:bcprov-jdk15on</exclude>
974974
<exclude>org.bouncycastle:bcpkix-jdk15on</exclude>
975975
<exclude>org.bouncycastle:bctls-jdk15on</exclude>
976-
<exclude>mysql:mysql-connector-java</exclude>
976+
<exclude>com.mysql:mysql-connector-j</exclude>
977977
<exclude>org.apache.cloudstack:cloud-plugin-storage-volume-storpool</exclude>
978978
<exclude>org.apache.cloudstack:cloud-plugin-storage-volume-linstor</exclude>
979979
<exclude>org.apache.cloudstack:cloud-usage</exclude>

‎developer/pom.xml

+6-6
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@
112112
<dependencies>
113113
<!-- specify the dependent jdbc driver here -->
114114
<dependency>
115-
<groupId>mysql</groupId>
116-
<artifactId>mysql-connector-java</artifactId>
115+
<groupId>com.mysql</groupId>
116+
<artifactId>mysql-connector-j</artifactId>
117117
<version>${cs.mysql.version}</version>
118118
</dependency>
119119
</dependencies>
@@ -180,8 +180,8 @@
180180
<version>1.2.1</version>
181181
<dependencies>
182182
<dependency>
183-
<groupId>mysql</groupId>
184-
<artifactId>mysql-connector-java</artifactId>
183+
<groupId>com.mysql</groupId>
184+
<artifactId>mysql-connector-j</artifactId>
185185
<version>${cs.mysql.version}</version>
186186
</dependency>
187187
</dependencies>
@@ -238,8 +238,8 @@
238238
<version>1.2.1</version>
239239
<dependencies>
240240
<dependency>
241-
<groupId>mysql</groupId>
242-
<artifactId>mysql-connector-java</artifactId>
241+
<groupId>com.mysql</groupId>
242+
<artifactId>mysql-connector-j</artifactId>
243243
<version>${cs.mysql.version}</version>
244244
</dependency>
245245
</dependencies>

‎engine/schema/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@
4949
<version>${project.version}</version>
5050
</dependency>
5151
<dependency>
52-
<groupId>mysql</groupId>
53-
<artifactId>mysql-connector-java</artifactId>
52+
<groupId>com.mysql</groupId>
53+
<artifactId>mysql-connector-j</artifactId>
5454
</dependency>
5555
<dependency>
5656
<groupId>org.ini4j</groupId>

‎engine/schema/src/main/java/com/cloud/upgrade/DatabaseCreator.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ private static void runScript(Connection conn, Reader reader, String filename, b
7474

7575
private static void runQuery(String host, String port, String rootPassword, String query, boolean dryRun) {
7676
System.out.println("============> Running query: " + query);
77-
try (Connection conn = DriverManager.getConnection(String.format("jdbc:mysql://%s:%s/", host, port), "root", rootPassword);
77+
try (Connection conn = DriverManager.getConnection(String.format("jdbc:mysql://%s:%s/?" + TransactionLegacy.CONNECTION_PARAMS, host, port), "root", rootPassword);
7878
Statement stmt = conn.createStatement();){
7979
if (!dryRun)
8080
stmt.executeUpdate(query);

‎framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ public class TransactionLegacy implements Closeable {
8282
public static final short SIMULATOR_DB = 3;
8383

8484
public static final short CONNECTED_DB = -1;
85+
public static final String CONNECTION_PARAMS = "scrollTolerantForwardOnly=true";
8586

8687
private static AtomicLong s_id = new AtomicLong();
8788
private static final TransactionMBeanImpl s_mbean = new TransactionMBeanImpl();
@@ -1211,6 +1212,9 @@ protected static String buildConnectionUri(String loadBalanceStrategy, String dr
12111212
connectionUri.append(loadBalanceStrategy);
12121213
}
12131214

1215+
connectionUri.append("&");
1216+
connectionUri.append(CONNECTION_PARAMS);
1217+
12141218
return connectionUri.toString();
12151219
}
12161220

@@ -1275,7 +1279,7 @@ private static String getDBHAParams(String dbName, Properties dbProps) {
12751279

12761280
@SuppressWarnings({"unchecked", "rawtypes"})
12771281
private static DataSource getDefaultDataSource(final String database) {
1278-
final ConnectionFactory connectionFactory = new DriverManagerConnectionFactory("jdbc:mysql://localhost:3306/" + database, "cloud", "cloud");
1282+
final ConnectionFactory connectionFactory = new DriverManagerConnectionFactory("jdbc:mysql://localhost:3306/" + database + "?" + CONNECTION_PARAMS, "cloud", "cloud");
12791283
final PoolableConnectionFactory poolableConnectionFactory = new PoolableConnectionFactory(connectionFactory, null);
12801284
final GenericObjectPool connectionPool = new GenericObjectPool(poolableConnectionFactory);
12811285
return new PoolingDataSource(connectionPool);

‎plugins/database/mysql-ha/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
</parent>
3030
<dependencies>
3131
<dependency>
32-
<groupId>mysql</groupId>
33-
<artifactId>mysql-connector-java</artifactId>
32+
<groupId>com.mysql</groupId>
33+
<artifactId>mysql-connector-j</artifactId>
3434
<scope>provided</scope>
3535
</dependency>
3636
</dependencies>

‎plugins/database/quota/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@
4949
<version>${project.version}</version>
5050
</dependency>
5151
<dependency>
52-
<groupId>mysql</groupId>
53-
<artifactId>mysql-connector-java</artifactId>
52+
<groupId>com.mysql</groupId>
53+
<artifactId>mysql-connector-j</artifactId>
5454
<scope>provided</scope>
5555
</dependency>
5656
<dependency>

‎plugins/network-elements/juniper-contrail/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@
120120
</exclusions>
121121
</dependency>
122122
<dependency>
123-
<groupId>mysql</groupId>
124-
<artifactId>mysql-connector-java</artifactId>
123+
<groupId>com.mysql</groupId>
124+
<artifactId>mysql-connector-j</artifactId>
125125
<scope>provided</scope>
126126
</dependency>
127127
<dependency>

‎plugins/storage/volume/cloudbyte/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
<version>${project.version}</version>
4040
</dependency>
4141
<dependency>
42-
<groupId>mysql</groupId>
43-
<artifactId>mysql-connector-java</artifactId>
42+
<groupId>com.mysql</groupId>
43+
<artifactId>mysql-connector-j</artifactId>
4444
<scope>provided</scope>
4545
</dependency>
4646
<dependency>

‎pom.xml

+3-3
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@
164164
<cs.kafka-clients.version>2.7.0</cs.kafka-clients.version>
165165
<cs.libvirt-java.version>0.5.3</cs.libvirt-java.version>
166166
<cs.mail.version>1.5.0-b01</cs.mail.version>
167-
<cs.mysql.version>8.0.19</cs.mysql.version>
167+
<cs.mysql.version>8.0.33</cs.mysql.version>
168168
<cs.neethi.version>2.0.4</cs.neethi.version>
169169
<cs.nitro.version>10.1</cs.nitro.version>
170170
<cs.opensaml.version>2.6.6</cs.opensaml.version>
@@ -453,8 +453,8 @@
453453
<version>${cs.reload4j.version}</version>
454454
</dependency>
455455
<dependency>
456-
<groupId>mysql</groupId>
457-
<artifactId>mysql-connector-java</artifactId>
456+
<groupId>com.mysql</groupId>
457+
<artifactId>mysql-connector-j</artifactId>
458458
<version>${cs.mysql.version}</version>
459459
<scope>test</scope>
460460
</dependency>

‎server/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535

3636
<dependencies>
3737
<dependency>
38-
<groupId>mysql</groupId>
39-
<artifactId>mysql-connector-java</artifactId>
38+
<groupId>com.mysql</groupId>
39+
<artifactId>mysql-connector-j</artifactId>
4040
</dependency>
4141
<dependency>
4242
<groupId>commons-io</groupId>

‎test/src-not-used/main/java/com/cloud/test/regression/TestCase.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public void setConn(String dbPassword) {
8585
this.conn = null;
8686
try {
8787
Class.forName("com.mysql.jdbc.Driver");
88-
this.conn = DriverManager.getConnection("jdbc:mysql://" + param.get("db") + "/cloud", "root", dbPassword);
88+
this.conn = DriverManager.getConnection("jdbc:mysql://" + param.get("db") + "/cloud?" + TransactionLegacy.CONNECTION_PARAMS, "root", dbPassword);
8989
if (!this.conn.isValid(0)) {
9090
s_logger.error("Connection to DB failed to establish");
9191
}

‎tools/devcloud-kvm/pom.xml

+4-4
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
</parent>
3131
<dependencies>
3232
<dependency>
33-
<groupId>mysql</groupId>
34-
<artifactId>mysql-connector-java</artifactId>
33+
<groupId>com.mysql</groupId>
34+
<artifactId>mysql-connector-j</artifactId>
3535
<scope>provided</scope>
3636
</dependency>
3737
<dependency>
@@ -80,8 +80,8 @@
8080
<dependencies>
8181
<!-- specify the dependent jdbc driver here -->
8282
<dependency>
83-
<groupId>mysql</groupId>
84-
<artifactId>mysql-connector-java</artifactId>
83+
<groupId>com.mysql</groupId>
84+
<artifactId>mysql-connector-j</artifactId>
8585
<version>${cs.mysql.version}</version>
8686
</dependency>
8787
</dependencies>

‎tools/devcloud4/pom.xml

+4-4
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
</parent>
3131
<dependencies>
3232
<dependency>
33-
<groupId>mysql</groupId>
34-
<artifactId>mysql-connector-java</artifactId>
33+
<groupId>com.mysql</groupId>
34+
<artifactId>mysql-connector-j</artifactId>
3535
<scope>provided</scope>
3636
</dependency>
3737
<dependency>
@@ -80,8 +80,8 @@
8080
<dependencies>
8181
<!-- specify the dependent jdbc driver here -->
8282
<dependency>
83-
<groupId>mysql</groupId>
84-
<artifactId>mysql-connector-java</artifactId>
83+
<groupId>com.mysql</groupId>
84+
<artifactId>mysql-connector-j</artifactId>
8585
<version>${cs.mysql.version}</version>
8686
</dependency>
8787
</dependencies>

‎tools/marvin/setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
raise RuntimeError("python setuptools is required to build Marvin")
2828

2929

30-
VERSION = "4.19.1.0-SNAPSHOT"
30+
VERSION = "4.19.1.0"
3131

3232
setup(name="Marvin",
3333
version=VERSION,

‎usage/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@
5959
<artifactId>commons-daemon</artifactId>
6060
</dependency>
6161
<dependency>
62-
<groupId>mysql</groupId>
63-
<artifactId>mysql-connector-java</artifactId>
62+
<groupId>com.mysql</groupId>
63+
<artifactId>mysql-connector-j</artifactId>
6464
<scope>provided</scope>
6565
</dependency>
6666
<dependency>

‎usage/src/test/java/com/cloud/usage/UsageSanityCheckerIT.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import org.mockito.Mockito;
4242

4343
import com.cloud.utils.PropertiesUtil;
44+
import com.cloud.utils.db.TransactionLegacy;
4445

4546
@RunWith(Parameterized.class)
4647
public class UsageSanityCheckerIT{
@@ -106,7 +107,7 @@ public static Collection<Object[]> data() {
106107
protected Connection createConnection(String dbSchema) throws SQLException {
107108
String cloudDbUrl = "jdbc:mysql://"+properties.getProperty("db."+dbSchema+".host") +
108109
":" + properties.getProperty("db."+dbSchema+".port") + "/" +
109-
properties.getProperty("db."+dbSchema+".name");
110+
properties.getProperty("db."+dbSchema+".name") + "?" + TransactionLegacy.CONNECTION_PARAMS;
110111
return DriverManager.getConnection(cloudDbUrl, properties.getProperty("db."+dbSchema+".username"),
111112
properties.getProperty("db."+dbSchema+".password"));
112113
}

‎utils/pom.xml

+3-2
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,9 @@
125125
</dependency>
126126
<!-- Test dependency in mysql for db tests -->
127127
<dependency>
128-
<groupId>mysql</groupId>
129-
<artifactId>mysql-connector-java</artifactId>
128+
<groupId>com.mysql</groupId>
129+
<artifactId>mysql-connector-j</artifactId>
130+
<version>${cs.mysql.version}</version>
130131
<scope>test</scope>
131132
</dependency>
132133
<dependency>

0 commit comments

Comments
 (0)