VMware: Improve error messaging / logs when starting non-user VMs, and secondary storage not available or doesn't have enough capacity (apache#9207)

sureshanaparti · web-flow · commit 620ed164d8ba · 2024-06-25T12:25:42.000+05:30
diff --git a/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java b/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java
@@ -201,7 +201,7 @@ public int compare(DataStore store1, DataStore store2) {
 
         // No store with space found
         s_logger.error(String.format("Can't find an image storage in zone with less than %d usage",
-                Math.round(_statsCollector.getImageStoreCapacityThreshold()*100)));
+                Math.round(_statsCollector.getImageStoreCapacityThreshold() * 100)));
         return null;
     }
 
diff --git a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
@@ -562,7 +562,6 @@ public List<ManagedObjectReference> addHostToPodCluster(VmwareContext serviceCon
 
     @Override
     public Pair<String, Long> getSecondaryStorageStoreUrlAndId(long dcId) {
-
         String secUrl = null;
         Long secId = null;
         DataStore secStore = _dataStoreMgr.getImageStoreWithFreeCapacity(dcId);
@@ -572,18 +571,17 @@ public Pair<String, Long> getSecondaryStorageStoreUrlAndId(long dcId) {
         }
 
         if (secUrl == null) {
-            // we are using non-NFS image store, then use cache storage instead
-            s_logger.info("Secondary storage is not NFS, we need to use staging storage");
+            s_logger.info("Secondary storage is either not having free capacity or not NFS, then use cache/staging storage instead");
             DataStore cacheStore = _dataStoreMgr.getImageCacheStore(dcId);
             if (cacheStore != null) {
                 secUrl = cacheStore.getUri();
                 secId = cacheStore.getId();
             } else {
-                s_logger.warn("No staging storage is found when non-NFS secondary storage is used");
+                s_logger.warn("No cache/staging storage found when NFS secondary storage with free capacity not available or non-NFS secondary storage is used");
             }
         }
 
-        return new Pair<String, Long>(secUrl, secId);
+        return new Pair<>(secUrl, secId);
     }
 
     @Override
@@ -599,13 +597,12 @@ public List<Pair<String, Long>> getSecondaryStorageStoresUrlAndIdList(long dcId)
         }
 
         if (urlIdList.isEmpty()) {
-            // we are using non-NFS image store, then use cache storage instead
-            s_logger.info("Secondary storage is not NFS, we need to use staging storage");
+            s_logger.info("Secondary storage is either not having free capacity or not NFS, then use cache/staging storage instead");
             DataStore cacheStore = _dataStoreMgr.getImageCacheStore(dcId);
             if (cacheStore != null) {
                 urlIdList.add(new Pair<>(cacheStore.getUri(), cacheStore.getId()));
             } else {
-                s_logger.warn("No staging storage is found when non-NFS secondary storage is used");
+                s_logger.warn("No cache/staging storage found when NFS secondary storage with free capacity not available or non-NFS secondary storage is used");
             }
         }
 
diff --git a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
@@ -48,6 +48,7 @@
 import javax.naming.ConfigurationException;
 import javax.xml.datatype.XMLGregorianCalendar;
 
+import com.cloud.capacity.CapacityManager;
 import com.cloud.hypervisor.vmware.mo.HostDatastoreBrowserMO;
 import com.vmware.vim25.FileInfo;
 import com.vmware.vim25.FileQueryFlags;
@@ -2279,15 +2280,15 @@ protected StartAnswer execute(StartCommand cmd) {
                 // attach ISO (for patching of system VM)
                 Pair<String, Long> secStoreUrlAndId = mgr.getSecondaryStorageStoreUrlAndId(Long.parseLong(_dcId));
                 String secStoreUrl = secStoreUrlAndId.first();
-                Long secStoreId = secStoreUrlAndId.second();
                 if (secStoreUrl == null) {
-                    String msg = "secondary storage for dc " + _dcId + " is not ready yet?";
+                    String msg = String.format("NFS secondary or cache storage of dc %s either doesn't have enough capacity (has reached %d%% usage threshold) or not ready yet, or non-NFS secondary storage is used",
+                            _dcId, Math.round(CapacityManager.SecondaryStorageCapacityThreshold.value() * 100));
                     throw new Exception(msg);
                 }
 
                 ManagedObjectReference morSecDs = prepareSecondaryDatastoreOnHost(secStoreUrl);
                 if (morSecDs == null) {
-                    String msg = "Failed to prepare secondary storage on host, secondary store url: " + secStoreUrl;
+                    String msg = "Failed to prepare secondary storage on host, NFS secondary or cache store url: " + secStoreUrl + " in dc "+ _dcId;
                     throw new Exception(msg);
                 }
                 DatastoreMO secDsMo = new DatastoreMO(hyperHost.getContext(), morSecDs);
@@ -4613,15 +4614,15 @@ protected Answer execute(PrepareForMigrationCommand cmd) {
             List<Pair<String, Long>> secStoreUrlAndIdList = mgr.getSecondaryStorageStoresUrlAndIdList(Long.parseLong(_dcId));
             for (Pair<String, Long> secStoreUrlAndId : secStoreUrlAndIdList) {
                 String secStoreUrl = secStoreUrlAndId.first();
-                Long secStoreId = secStoreUrlAndId.second();
                 if (secStoreUrl == null) {
-                    String msg = String.format("Secondary storage for dc %s is not ready yet?", _dcId);
+                    String msg = String.format("NFS secondary or cache storage of dc %s either doesn't have enough capacity (has reached %d%% usage threshold) or not ready yet, or non-NFS secondary storage is used",
+                            _dcId, Math.round(CapacityManager.SecondaryStorageCapacityThreshold.value() * 100));
                     throw new Exception(msg);
                 }
 
                 ManagedObjectReference morSecDs = prepareSecondaryDatastoreOnHost(secStoreUrl);
                 if (morSecDs == null) {
-                    String msg = "Failed to prepare secondary storage on host, secondary store url: " + secStoreUrl;
+                    String msg = "Failed to prepare secondary storage on host, NFS secondary or cache store url: " + secStoreUrl + " in dc "+ _dcId;
                     throw new Exception(msg);
                 }
             }
@@ -7342,14 +7343,14 @@ private List<VolumeObjectTO> relocateVirtualMachine(final VmwareHypervisorHost h
                 VmwareManager mgr = targetHyperHost.getContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
                 Pair<String, Long> secStoreUrlAndId = mgr.getSecondaryStorageStoreUrlAndId(Long.parseLong(_dcId));
                 String secStoreUrl = secStoreUrlAndId.first();
-                Long secStoreId = secStoreUrlAndId.second();
                 if (secStoreUrl == null) {
-                    String msg = "secondary storage for dc " + _dcId + " is not ready yet?";
+                    String msg = String.format("NFS secondary or cache storage of dc %s either doesn't have enough capacity (has reached %d%% usage threshold) or not ready yet, or non-NFS secondary storage is used",
+                            _dcId, Math.round(CapacityManager.SecondaryStorageCapacityThreshold.value() * 100));
                     throw new Exception(msg);
                 }
                 ManagedObjectReference morSecDs = prepareSecondaryDatastoreOnSpecificHost(secStoreUrl, targetHyperHost);
                 if (morSecDs == null) {
-                    throw new Exception(String.format("Failed to prepare secondary storage on host, secondary store url: %s", secStoreUrl));
+                    throw new Exception(String.format("Failed to prepare secondary storage on host, NFS secondary or cache store url: %s in dc %s", secStoreUrl, _dcId));
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ public int compare(DataStore store1, DataStore store2) {`
`201`	`201`
`202`	`202`	`// No store with space found`
`203`	`203`	`s_logger.error(String.format("Can't find an image storage in zone with less than %d usage",`
`204`		`- Math.round(_statsCollector.getImageStoreCapacityThreshold()*100)));`
	`204`	`+ Math.round(_statsCollector.getImageStoreCapacityThreshold() * 100)));`
`205`	`205`	`return null;`
`206`	`206`	`}`
`207`	`207`
Original file line number	Diff line number	Diff line change
`@@ -562,7 +562,6 @@ public List<ManagedObjectReference> addHostToPodCluster(VmwareContext serviceCon`
`562`	`562`
`563`	`563`	`@Override`
`564`	`564`	`public Pair<String, Long> getSecondaryStorageStoreUrlAndId(long dcId) {`
`565`		`-`
`566`	`565`	`String secUrl = null;`
`567`	`566`	`Long secId = null;`
`568`	`567`	`DataStore secStore = _dataStoreMgr.getImageStoreWithFreeCapacity(dcId);`
`@@ -572,18 +571,17 @@ public Pair<String, Long> getSecondaryStorageStoreUrlAndId(long dcId) {`
`572`	`571`	`}`
`573`	`572`
`574`	`573`	`if (secUrl == null) {`
`575`		`- // we are using non-NFS image store, then use cache storage instead`
`576`		`- s_logger.info("Secondary storage is not NFS, we need to use staging storage");`
	`574`	`+ s_logger.info("Secondary storage is either not having free capacity or not NFS, then use cache/staging storage instead");`
`577`	`575`	`DataStore cacheStore = _dataStoreMgr.getImageCacheStore(dcId);`
`578`	`576`	`if (cacheStore != null) {`
`579`	`577`	`secUrl = cacheStore.getUri();`
`580`	`578`	`secId = cacheStore.getId();`
`581`	`579`	`} else {`
`582`		`- s_logger.warn("No staging storage is found when non-NFS secondary storage is used");`
	`580`	`+ s_logger.warn("No cache/staging storage found when NFS secondary storage with free capacity not available or non-NFS secondary storage is used");`
`583`	`581`	`}`
`584`	`582`	`}`
`585`	`583`
`586`		`- return new Pair<String, Long>(secUrl, secId);`
	`584`	`+ return new Pair<>(secUrl, secId);`
`587`	`585`	`}`
`588`	`586`
`589`	`587`	`@Override`
`@@ -599,13 +597,12 @@ public List<Pair<String, Long>> getSecondaryStorageStoresUrlAndIdList(long dcId)`
`599`	`597`	`}`
`600`	`598`
`601`	`599`	`if (urlIdList.isEmpty()) {`
`602`		`- // we are using non-NFS image store, then use cache storage instead`
`603`		`- s_logger.info("Secondary storage is not NFS, we need to use staging storage");`
	`600`	`+ s_logger.info("Secondary storage is either not having free capacity or not NFS, then use cache/staging storage instead");`
`604`	`601`	`DataStore cacheStore = _dataStoreMgr.getImageCacheStore(dcId);`
`605`	`602`	`if (cacheStore != null) {`
`606`	`603`	`urlIdList.add(new Pair<>(cacheStore.getUri(), cacheStore.getId()));`
`607`	`604`	`} else {`
`608`		`- s_logger.warn("No staging storage is found when non-NFS secondary storage is used");`
	`605`	`+ s_logger.warn("No cache/staging storage found when NFS secondary storage with free capacity not available or non-NFS secondary storage is used");`
`609`	`606`	`}`
`610`	`607`	`}`
`611`	`608`