Clean up module details

Author: rreusser

.eslintrc

@@ -7,6 +7,31 @@
     }
   },
   "rules": {
-    "semi": 2
-  }
+    "semi": 2,
+    "no-unused-vars": 2,
+    "react/display-name": 2,
+    "react/jsx-key": 2,
+    "react/jsx-no-comment-textnodes": 2,
+    "react/jsx-no-duplicate-props": 2,
+    "react/jsx-no-target-blank": 2,
+    "react/jsx-no-undef": 2,
+    "react/jsx-uses-react": 2,
+    "react/jsx-uses-vars": 2,
+    "react/no-children-prop": 2,
+    "react/no-danger-with-children": 2,
+    "react/no-deprecated": 2,
+    "react/no-direct-mutation-state": 2,
+    "react/no-find-dom-node": 2,
+    "react/no-is-mounted": 2,
+    "react/no-render-return-value": 2,
+    "react/no-string-refs": 2,
+    "react/no-unescaped-entities": 2,
+    "react/no-unknown-property": 2,
+    "react/prop-types": 2,
+    "react/react-in-jsx-scope": 2,
+    "react/require-render-return": 2,
+  },
+  "plugins": [
+    "react"
+  ]
 }

README.md

@@ -42,9 +42,9 @@ The only requirement is that plotly.js is loaded before you inject it. You may n
 | `frames` | `Array` | `undefined` | list of frame objects |
 | `fit` | `Boolean` | `false` | When true, disregards `layout.width` and `layout.height` and fits to the parent div size, updating on `window.resize` |
 | `debug` | `Boolean` | `false` | Assign the graph div to `window.gd` for debugging |
-| `onInitialized | `Function` | null | Callback executed once after plot is initialized |
-| `onUpdate | `Function` | null | Callback executed when a plotly.js API method is invoked |
-| `onError | `Function` | null | Callback executed when a plotly.js API method rejects |
+| `onInitialized` | `Function` | null | Callback executed once after plot is initialized |
+| `onUpdate` | `Function` | null | Callback executed when a plotly.js API method is invoked |
+| `onError` | `Function` | null | Callback executed when a plotly.js API method rejects |
 
 ### Event handler props
 

package.json

@@ -15,7 +15,7 @@
   "scripts": {
     "start": "budo example/src/index.js --dir example/src --dir example --open --live --host localhost -- -p [ css-modulesify --after autoprefixer --autoprefixer.browsers \"> 5%\" -o example/assets/styles.css ] -t [ babelify --presets [ es2015 react ] --plugins transform-class-properties ] -t brfs",
     "example:build:html": "cp example/src/index.html example/dist/index.html",
-    "example:build:js": "browserify example/src/index.js -p [ css-modulesify --after autoprefixer --autoprefixer.browsers \"> 5%\" -o example/dist/styles.css ] -t [ babelify --presets [ es2015 react ] --plugins transform-class-properties ] -t brfs -g [ envify --NODE_ENV production ] -g uglifyify -p bundle-collapser/plugin | uglifyjs --compress --mangle > example/dist/index.js",
+    "example:build:js": "browserify example/src/index.js -p [ css-modulesify --after autoprefixer --autoprefixer.browsers \"> 5%\" -o example/dist/styles.css ] -t [ babelify --presets [ es2015 react ] --plugins transform-class-properties ] -t brfs -g [ envify --NODE_ENV production ] -p bundle-collapser/plugin | uglifyjs --compress --mangle > example/dist/index.js",
     "example:build:assets": "rm -rf example/dist/assets && cp -r example/assets example/dist/assets",
     "example:build": "rm -rf example/dist && mkdir -p example/dist && npm run example:build:html && npm run example:build:js && npm run example:build:assets",
     "example:deploy": "netlify deploy example/dist",
@@ -56,6 +56,7 @@
     "envify": "^4.1.0",
     "enzyme": "^2.9.1",
     "eslint": "^4.8.0",
+    "eslint-plugin-react": "^7.4.0",
     "event-emitter": "^0.3.5",
     "gl": "^4.0.4",
     "husky": "^0.14.3",
@@ -66,7 +67,6 @@
     "netlify-cli": "^1.2.2",
     "nodemon": "^1.11.0",
     "onetime": "^1.1.0",
-    "plotly.js": "^1.29.2",
     "prettier": "^1.5.3",
     "react": "^15.6.1",
     "react-addons-test-utils": "^15.6.0",
@@ -75,8 +75,10 @@
     "react-dom": "^15.6.1",
     "react-test-renderer": "^15.6.1",
     "throttle-debounce": "^1.0.1",
-    "uglify-js": "^3.0.26",
-    "uglifyify": "^4.0.3"
+    "uglify-js": "^3.0.26"
+  },
+  "peerDependencies": {
+    "plotly.js": ">1.0.0"
   },
   "browserify-global-shim": {
     "react": "React"

src/__mocks__/plotly.js

@@ -31,7 +31,7 @@ export default {
     }, ASYNC_DELAY);
   }),
   update: jest.fn(),
-  purge: jest.fn(gd => {
+  purge: jest.fn(() => {
     state.gd = nll;
   }),
 };

src/__tests__/react-plotly.test.js

@@ -1,5 +1,5 @@
 import React from "react";
-import { mount, shallow } from "enzyme";
+import { mount } from "enzyme";
 import createComponent from "../react-plotly";
 import once from "onetime";
 
@@ -141,7 +141,6 @@ describe("<Plotly/>", () => {
     describe("responding to window events", () => {
       describe("with fit: true", () => {
         test("does not call relayout on initialization", done => {
-          let relayoutCnt = 0;
           createPlot({
             fit: true,
             onRelayout: () => done.fail("Unexpected relayout event"),
@@ -172,7 +171,6 @@ describe("<Plotly/>", () => {
 
       describe("with fit: false", () => {
         test("does not call relayout on init", done => {
-          let relayoutCnt = 0;
           createPlot({
             fit: false,
             onRelayout: () => done.fail("Unexpected relayout event"),
@@ -184,7 +182,6 @@ describe("<Plotly/>", () => {
         });
 
         test("does not call relayout on window resize", done => {
-          let relayoutCnt = 0;
           createPlot({
             fit: false,
             onRelayout: () => done.fail("Unexpected relayout event"),

src/react-plotly.js

@@ -2,11 +2,7 @@ import React, { Component } from "react";
 import PropTypes from "prop-types";
 import isNumeric from "fast-isnumeric";
 import objectAssign from "object-assign";
-import throttle from "throttle-debounce/throttle";
-
-function constructUpdate(diff) {
-  var keys = Object.keys(diff);
-}
+// import throttle from "throttle-debounce/throttle";
 
 // The naming convention is:
 //   - events are attached as `'plotly_' + eventName.toLowerCase()`
@@ -95,7 +91,6 @@ export default function createPlotlyComponent(Plotly) {
     }
 
     componentWillReceiveProps(nextProps) {
-      let dataDiff, layoutDiff, configDiff;
       let nextLayout = this.sizeAdjustedLayout(nextProps.layout);
 
       this.p = this.p
@@ -256,14 +251,17 @@ export default function createPlotlyComponent(Plotly) {
     layout: PropTypes.object,
     frames: PropTypes.arrayOf(PropTypes.object),
     onInitialized: PropTypes.func,
+    onError: PropTypes.func,
+    onUpdate: PropTypes.func,
+    debug: PropTypes.bool,
   };
 
   for (let i = 0; i < eventNames.length; i++) {
     PlotlyComponent.propTypes["on" + eventNames[i]] = PropTypes.func;
   }
 
   PlotlyComponent.defaultProps = {
-    debug: true,
+    debug: false,
     fit: false,
     data: [],
   };