fix(wayland): fix issue with tiled and maximized window

[aliaksandr-trush]

Fix for #6262

Tested on Gnome 47 and Cosmic DE
Tested with window_decorations = RESIZE and NONE

[KiaraGrouwstra]

this change fixed the resizing bug for me, running niri on nixos. thank you!

[Gurjaka]

we need this merged

[Gurjaka]

@wez can you get this merged pls?

[39555]

@wez We need you 🙏 and your announcement regarding the project. Maybe you could find some additional maintainers. There is a lot of cool and important PRs that have been sitting for months

[Gurjaka]

@wez We need you 🙏 and your announcement regarding the project. Maybe you could find some additional maintainers. There is a lot of cool and important PRs that have been sitting for months

ეეე ქართველი გაიჩითა

[my4ng]

Can confirm working very nicely on niri, thank you! One tiny issue is that the resizing animation is absent from upsizing but present during downsizing

EDIT: this is because I used the main branch rather than the fix_wayland branch so it's the old wezterm release version... Just realised this and now it's perfect, sorry, silly me 🤦‍♂️!

[jorgenman]

I'm not using niri, but this appears to fix the problem for me on Fedora 41 with KDE Plasma 6.2.5. Thanks!

[MartenBE]

@wez can you get this merged pls?

Perhaps @bew could take a look at this?

[bew]

Hello o/
I'm not sure what good my look can do here, as I don't have any more rights than you guys, and I personally don't use Wayland on my Linux yet..

I'm still curious though 👀:
Could you maybe explain to me why these changes help with the issue as I'm not too familiar with the Wayland side and how it works 🤔

[KiaraGrouwstra]

@bew: on niri / compliant wayland, due to a regression it was no longer possible to resize wezterm beyond a given width. this PR addresses that.

[aliaksandr-trush]

I'm still curious though 👀: Could you maybe explain to me why these changes help with the issue as I'm not too familiar with the Wayland side and how it works 🤔

I am not really familiar about internal Wayland implementation, but extra wl_surface().commit() call causing Wayland to store some wrong information about window size. And on Wayland Configure event it returns this incorrect data, that we are using for window drawing.
Without such wl_surface().commit() call we are receiving only correct Configure event information, and we can get rid of hack with using configure.suggested_bounds.
The fix was found mostly in imperative way.

[wez]

Thank you!