fix: fix stack-tracking tailing new line issue (#13)

Author: whatasoda

src/utils/__tests__/stack-tracking.test.ts

@@ -1,4 +1,4 @@
-import { withStackTracking } from '../stack-tracking';
+import { parseStack, withStackTracking } from '../stack-tracking';
 
 describe('withStackTracking', () => {
   it('works correctly', () => {
@@ -33,3 +33,67 @@ describe('withStackTracking', () => {
     });
   });
 });
+
+const stack0 = `Error:
+    at /foo/bar/buz.js:12:34
+    at /foo/bar/buz/qux.js:56:789`;
+
+const stack1 = `Error:
+    at Map.forEach (/foo/bar/buz.js:12:34)
+    at Map.forEach (/foo/bar/buz/qux.js:56:789)`;
+
+describe('parseStack', () => {
+  it('parses stack text into CodeStack', () => {
+    expect(parseStack(stack0, 0)).toEqual({
+      composed: '/foo/bar/buz.js:12:34',
+      filename: '/foo/bar/buz.js',
+      line: 12,
+      col: 34,
+    });
+    expect(parseStack(stack0, 1)).toEqual({
+      composed: '/foo/bar/buz/qux.js:56:789',
+      filename: '/foo/bar/buz/qux.js',
+      line: 56,
+      col: 789,
+    });
+    expect(parseStack(stack1, 0)).toEqual({
+      composed: '/foo/bar/buz.js:12:34',
+      filename: '/foo/bar/buz.js',
+      line: 12,
+      col: 34,
+    });
+    expect(parseStack(stack1, 1)).toEqual({
+      composed: '/foo/bar/buz/qux.js:56:789',
+      filename: '/foo/bar/buz/qux.js',
+      line: 56,
+      col: 789,
+    });
+  });
+
+  it('uses deepest stack if received too much depth', () => {
+    expect(parseStack(stack0, 2)).toEqual({
+      composed: '/foo/bar/buz/qux.js:56:789',
+      filename: '/foo/bar/buz/qux.js',
+      line: 56,
+      col: 789,
+    });
+    expect(parseStack(stack0, 100)).toEqual({
+      composed: '/foo/bar/buz/qux.js:56:789',
+      filename: '/foo/bar/buz/qux.js',
+      line: 56,
+      col: 789,
+    });
+    expect(parseStack(stack1, 2)).toEqual({
+      composed: '/foo/bar/buz/qux.js:56:789',
+      filename: '/foo/bar/buz/qux.js',
+      line: 56,
+      col: 789,
+    });
+    expect(parseStack(stack1, 100)).toEqual({
+      composed: '/foo/bar/buz/qux.js:56:789',
+      filename: '/foo/bar/buz/qux.js',
+      line: 56,
+      col: 789,
+    });
+  });
+});

src/utils/stack-tracking.ts

@@ -5,15 +5,14 @@ export interface CodeStack {
   col: number;
 }
 
-const parseStack = (stack: string, depth: number): CodeStack => {
-  if (!stack) throw new Error('Invalid Stack Information: make sure to run with node');
+export const parseStack = (stack: string, depth: number): CodeStack => {
   let cursor = 0;
   for (let i = depth + 1; stack && i > 0; i--) {
-    cursor = stack.indexOf('\n', cursor) + 1;
+    cursor = stack.indexOf('\n', cursor + 1);
   }
-  // Ignore the case if the stack doesn't include any new line
+  cursor = (cursor === -1 ? stack.lastIndexOf('\n') : cursor) + 8 /* '____at_' */;
   const composed = stack
-    .slice(cursor + /* '____at_' ('_'=' ') */ 7, stack.indexOf('\n', cursor))
+    .slice(cursor, (stack.indexOf('\n', cursor) + 1 || Infinity) - 1)
     .replace(STACK_PARENTHESES, '');
 
   if (!stack) throw new Error('Invalid Stack Information: invalid depth');