style: clear old code by pint

Author: shaunthegeek

app/Http/Controllers/API/AuthController.php

@@ -3,7 +3,7 @@
 namespace App\Http\Controllers\API;
 
 use Illuminate\Http\Request;
-use App\Http\Controllers\Controller;
+use Illuminate\Routing\Controller;
 use Validator;
 
 class AuthController extends Controller
@@ -40,12 +40,12 @@ public function index(Request $request)
             'ip' => 'ip',
             'mac' => 'string',
         ]);
-        $user_status = -1;
+        $userStatus = -1;
         $status = 400;
         if (!$validator->fails()) {
-            $user_status = 1;
+            $userStatus = 1;
             $status = 200;
         }
-        return response()->txt('Auth: ' . $user_status, $status);
+        return response()->txt('Auth: ' . $userStatus, $status);
     }
 }

app/Http/Controllers/API/GatewayController.php

@@ -3,7 +3,7 @@
 namespace App\Http\Controllers\API;
 
 use Illuminate\Http\Request;
-use App\Http\Controllers\Controller;
+use Illuminate\Routing\Controller;
 use App\Models\Gateway;
 use Validator;
 
@@ -26,27 +26,27 @@ public function ping(Request $request)
             'sys_load' => 'required|numeric',
             'wifidog_uptime' => 'required|integer',
         ]);
-        $r = 'Error: params wrong';
+        $responseTxt = 'Error: params wrong';
         if ($validator->fails()) {
-            return response()->txt($r, 400);
+            return response()->txt($responseTxt, 400);
         }
         $input = $validator->getData();
         $input['id'] = $input['gw_id'];
         unset($input['gw_id']);
-        $status_code = 200;
+        $statusCode = 200;
         if (config('wifidog.allow_unknown_gateway')) {
             Gateway::updateOrCreate(['id' => $input['id']], $input);
-            $r = 'Pong';
-        } else {
-            $gw = Gateway::find($input['id']);
-            if (!empty($gw)) {
-                $gw->update($input);
-                $r = 'Pong';
-            } else {
-                $r = 'Error: not allow unknown gateway';
-                $status_code = 400;
-            }
+            $responseTxt = 'Pong';
+            return response()->txt($responseTxt, $statusCode);
         }
-        return response()->txt($r, $status_code);
+        $gateway = Gateway::find($input['id']);
+        if (!empty($gateway)) {
+            $gateway->update($input);
+            $responseTxt = 'Pong';
+            return response()->txt($responseTxt, $statusCode);
+        }
+        $responseTxt = 'Error: not allow unknown gateway';
+        $statusCode = 400;
+        return response()->txt($responseTxt, $statusCode);
     }
 }

app/Http/Controllers/DashboardController.php

@@ -2,8 +2,6 @@
 
 namespace App\Http\Controllers;
 
-use Illuminate\Support\Facades\Auth;
-
 class DashboardController extends Controller
 {
     /**
@@ -13,7 +11,6 @@ class DashboardController extends Controller
      */
     public function index()
     {
-        $user = auth()->user();
         $data = [];
         if (session('gw_address') && session('gw_port') && session('token')) {
             $data['wifidog_uri'] = "http://" . session('gw_address')

app/Http/Controllers/Welcome.php

@@ -2,17 +2,14 @@
 
 namespace App\Http\Controllers;
 
-use Illuminate\Http\Request;
-
 class Welcome extends Controller
 {
     /**
      * Handle the incoming request.
      *
-     * @param  \Illuminate\Http\Request  $request
      * @return \Illuminate\Http\Response
      */
-    public function __invoke(Request $request)
+    public function __invoke()
     {
         return view('welcome');
     }

database/factories/GatewayFactory.php

@@ -3,8 +3,6 @@
 namespace Database\Factories;
 
 use Illuminate\Database\Eloquent\Factories\Factory;
-use Illuminate\Support\Facades\Hash;
-use Illuminate\Support\Str;
 
 /**
  * @extends \Illuminate\Database\Eloquent\Factories\Factory<\App\Models\User>

database/factories/UserFactory.php

@@ -37,7 +37,7 @@ public function definition(): array
      */
     public function unverified(): static
     {
-        return $this->state(fn (array $attributes) => [
+        return $this->state(fn () => [
             'email_verified_at' => null,
         ]);
     }

database/migrations/0001_01_01_000000_create_users_table.php

@@ -4,8 +4,7 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class extends Migration
-{
+return new class () extends Migration {
     /**
      * Run the migrations.
      */

database/migrations/0001_01_01_000001_create_cache_table.php

@@ -4,8 +4,7 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class extends Migration
-{
+return new class () extends Migration {
     /**
      * Run the migrations.
      */

database/migrations/0001_01_01_000002_create_jobs_table.php

@@ -4,8 +4,7 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class extends Migration
-{
+return new class () extends Migration {
     /**
      * Run the migrations.
      */

database/migrations/2024_11_15_162815_create_personal_access_tokens_table.php

@@ -4,8 +4,7 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class extends Migration
-{
+return new class () extends Migration {
     /**
      * Run the migrations.
      */

tests/Feature/API/AuthControllerTest.php

@@ -5,7 +5,6 @@
 use Tests\TestCase;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use App\Models\User;
-use Illuminate\Support\Str;
 
 class AuthControllerTest extends TestCase
 {

tests/Feature/DashboardTest.php

@@ -21,8 +21,8 @@ public function testIndex()
                 'gw_port' => '2060',
                 'token' => $token,
             ])->get('/dashboard');
-        $wifidog_uri = "http://192.168.199.1:2060/wifidog/auth?token=" . $token;
-        $response->assertStatus(200)->assertViewHas('wifidog_uri', $wifidog_uri);
+        $wifidogUri = "http://192.168.199.1:2060/wifidog/auth?token=" . $token;
+        $response->assertStatus(200)->assertViewHas('wifidog_uri', $wifidogUri);
         $response->assertSeeText('start internet');
     }