Skip to content

Commit 523bd8e

Browse files
edg2sedg2s
committed
Use more arrow functions in tests
Change-Id: Icbbd36f615a85744275da84e0eb6147de1a8786f
1 parent da3c680 commit 523bd8e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+345
-419
lines changed

‎tests/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.test.js

+41-47
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ QUnit.module( 've.ce.LinearDeleteKeyDownHandler', {
1515

1616
QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
1717
const done = assert.async(),
18-
noChange = function () {},
18+
noChange = () => {},
1919
emptyList = '<ul><li><p></p></li></ul>',
2020
blockAlien = '<div rel="ve:Alien"></div>',
2121
blockAliens = blockAlien + '<p>a</p>' + blockAlien,
@@ -27,7 +27,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
2727
{
2828
rangeOrSelection: new ve.Range( 4 ),
2929
keys: [ 'BACKSPACE' ],
30-
expectedData: function ( data ) {
30+
expectedData: ( data ) => {
3131
data.splice( 3, 1 );
3232
},
3333
expectedRangeOrSelection: new ve.Range( 3 ),
@@ -37,7 +37,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
3737
{
3838
rangeOrSelection: new ve.Range( 3 ),
3939
keys: [ 'DELETE' ],
40-
expectedData: function ( data ) {
40+
expectedData: ( data ) => {
4141
data.splice( 3, 1 );
4242
},
4343
expectedRangeOrSelection: new ve.Range( 3 ),
@@ -55,7 +55,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
5555
{
5656
rangeOrSelection: new ve.Range( 1, 4 ),
5757
keys: [ 'BACKSPACE' ],
58-
expectedData: function ( data ) {
58+
expectedData: ( data ) => {
5959
data.splice( 1, 3 );
6060
},
6161
expectedRangeOrSelection: new ve.Range( 1 ),
@@ -64,7 +64,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
6464
{
6565
rangeOrSelection: new ve.Range( 1, 4 ),
6666
keys: [ 'DELETE' ],
67-
expectedData: function ( data ) {
67+
expectedData: ( data ) => {
6868
data.splice( 1, 3 );
6969
},
7070
expectedRangeOrSelection: new ve.Range( 1 ),
@@ -73,7 +73,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
7373
{
7474
rangeOrSelection: new ve.Range( 4 ),
7575
keys: [ 'CTRL+BACKSPACE' ],
76-
expectedData: function ( data ) {
76+
expectedData: ( data ) => {
7777
data.splice( 1, 3 );
7878
},
7979
expectedRangeOrSelection: new ve.Range( 1 ),
@@ -82,7 +82,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
8282
{
8383
rangeOrSelection: new ve.Range( 1 ),
8484
keys: [ 'CTRL+DELETE' ],
85-
expectedData: function ( data ) {
85+
expectedData: ( data ) => {
8686
data.splice( 1, 3 );
8787
},
8888
expectedRangeOrSelection: new ve.Range( 1 ),
@@ -91,7 +91,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
9191
{
9292
rangeOrSelection: new ve.Range( 56, 57 ),
9393
keys: [ 'DELETE', 'DELETE' ],
94-
expectedData: function ( data ) {
94+
expectedData: ( data ) => {
9595
data.splice( 55, 3 );
9696
},
9797
expectedRangeOrSelection: new ve.Range( 56 ),
@@ -114,7 +114,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
114114
{
115115
rangeOrSelection: new ve.Range( 39, 41 ),
116116
keys: [ 'DELETE' ],
117-
expectedData: function ( data ) {
117+
expectedData: ( data ) => {
118118
data.splice( 39, 2 );
119119
},
120120
expectedRangeOrSelection: new ve.Range( 39 ),
@@ -140,7 +140,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
140140
htmlOrDoc: blockAliens,
141141
rangeOrSelection: new ve.Range( 0, 2 ),
142142
keys: [ 'DELETE' ],
143-
expectedData: function ( data ) {
143+
expectedData: ( data ) => {
144144
data.splice( 0, 2 );
145145
},
146146
expectedRangeOrSelection: new ve.Range( 1 ),
@@ -150,7 +150,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
150150
htmlOrDoc: blockAliensEmptyParagraph,
151151
rangeOrSelection: new ve.Range( 3 ),
152152
keys: [ 'BACKSPACE' ],
153-
expectedData: function ( data ) {
153+
expectedData: ( data ) => {
154154
data.splice( 2, 2 );
155155
},
156156
expectedRangeOrSelection: new ve.Range( 0, 2 ),
@@ -160,7 +160,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
160160
htmlOrDoc: blockAliensEmptyParagraph,
161161
rangeOrSelection: new ve.Range( 3 ),
162162
keys: [ 'DELETE' ],
163-
expectedData: function ( data ) {
163+
expectedData: ( data ) => {
164164
data.splice( 2, 2 );
165165
},
166166
expectedRangeOrSelection: new ve.Range( 2, 4 ),
@@ -194,7 +194,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
194194
htmlOrDoc: tablesEmptyParagraph,
195195
rangeOrSelection: new ve.Range( 12 ),
196196
keys: [ 'BACKSPACE' ],
197-
expectedData: function ( data ) {
197+
expectedData: ( data ) => {
198198
data.splice( 11, 2 );
199199
},
200200
expectedRangeOrSelection: {
@@ -209,7 +209,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
209209
htmlOrDoc: tablesEmptyParagraph,
210210
rangeOrSelection: new ve.Range( 12 ),
211211
keys: [ 'DELETE' ],
212-
expectedData: function ( data ) {
212+
expectedData: ( data ) => {
213213
data.splice( 11, 2 );
214214
},
215215
expectedRangeOrSelection: {
@@ -225,7 +225,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
225225
htmlOrDoc: '<p>a</p>' + emptyList + '<p>b</p>',
226226
rangeOrSelection: new ve.Range( 6 ),
227227
keys: [ 'DELETE' ],
228-
expectedData: function ( data ) {
228+
expectedData: ( data ) => {
229229
data.splice( 3, 6 );
230230
},
231231
expectedRangeOrSelection: new ve.Range( 4 ),
@@ -235,7 +235,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
235235
htmlOrDoc: '<p>a</p>' + emptyList + '<p>b</p>',
236236
rangeOrSelection: new ve.Range( 6 ),
237237
keys: [ 'BACKSPACE' ],
238-
expectedData: function ( data ) {
238+
expectedData: ( data ) => {
239239
data.splice( 3, 6 );
240240
},
241241
expectedRangeOrSelection: new ve.Range( 2 ),
@@ -245,7 +245,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
245245
htmlOrDoc: '<p>a</p>' + emptyList + '<p>b</p>',
246246
rangeOrSelection: new ve.Range( 2 ),
247247
keys: [ 'DELETE' ],
248-
expectedData: function ( data ) {
248+
expectedData: ( data ) => {
249249
data.splice( 3, 6 );
250250
},
251251
expectedRangeOrSelection: new ve.Range( 2 ),
@@ -255,7 +255,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
255255
htmlOrDoc: '<p>a</p>' + emptyList + '<p>b</p>',
256256
rangeOrSelection: new ve.Range( 10 ),
257257
keys: [ 'BACKSPACE' ],
258-
expectedData: function ( data ) {
258+
expectedData: ( data ) => {
259259
data.splice( 3, 6 );
260260
},
261261
expectedRangeOrSelection: new ve.Range( 4 ),
@@ -265,7 +265,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
265265
htmlOrDoc: '<ul><li><p></p>' + emptyList + '</li></ul>',
266266
rangeOrSelection: new ve.Range( 7 ),
267267
keys: [ 'BACKSPACE' ],
268-
expectedData: function ( data ) {
268+
expectedData: ( data ) => {
269269
data.splice( 2, 2 );
270270
},
271271
expectedRangeOrSelection: new ve.Range( 5 ),
@@ -274,7 +274,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
274274
{
275275
rangeOrSelection: new ve.Range( 0, 61 ),
276276
keys: [ 'BACKSPACE' ],
277-
expectedData: function ( data ) {
277+
expectedData: ( data ) => {
278278
data.splice(
279279
0,
280280
61,
@@ -289,7 +289,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
289289
htmlOrDoc: emptyList + '<p>foo</p>',
290290
rangeOrSelection: new ve.Range( 3 ),
291291
keys: [ 'BACKSPACE' ],
292-
expectedData: function ( data ) {
292+
expectedData: ( data ) => {
293293
data.splice( 0, 2 );
294294
data.splice( 2, 2 );
295295
},
@@ -300,7 +300,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
300300
htmlOrDoc: '<p>foo</p>' + emptyList,
301301
rangeOrSelection: new ve.Range( 8 ),
302302
keys: [ 'DELETE' ],
303-
expectedData: function ( data ) {
303+
expectedData: ( data ) => {
304304
data.splice( 5, 2 );
305305
data.splice( 7, 2 );
306306
},
@@ -311,7 +311,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
311311
htmlOrDoc: '<p>foo</p><ul><li><p>bar</p></li></ul>',
312312
rangeOrSelection: new ve.Range( 11 ),
313313
keys: [ 'DELETE' ],
314-
expectedData: function ( data ) {
314+
expectedData: ( data ) => {
315315
data.splice( 5, 2 );
316316
data.splice( 10, 2 );
317317
},
@@ -322,7 +322,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
322322
htmlOrDoc: '<p>foo</p><ul><li><p>bar</p></li><li><p>baz</p></li></ul>',
323323
rangeOrSelection: new ve.Range( 18 ),
324324
keys: [ 'DELETE' ],
325-
expectedData: function ( data ) {
325+
expectedData: ( data ) => {
326326
const paragraph = data.splice( 14, 5 );
327327
data.splice( 13, 2 ); // Remove the empty listItem
328328
data.splice( 14, 0, ...paragraph );
@@ -334,7 +334,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
334334
htmlOrDoc: '<ul><li><p>foo</p></li><li><p>bar</p></li></ul>',
335335
rangeOrSelection: new ve.Range( 6 ),
336336
keys: [ 'DELETE' ],
337-
expectedData: function ( data ) {
337+
expectedData: ( data ) => {
338338
data.splice( 6, 4 );
339339
},
340340
expectedRangeOrSelection: new ve.Range( 6 ),
@@ -344,7 +344,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
344344
htmlOrDoc: '<ul><li><p>foo</p></li><li><p>bar</p></li></ul>',
345345
rangeOrSelection: new ve.Range( 10 ),
346346
keys: [ 'BACKSPACE' ],
347-
expectedData: function ( data ) {
347+
expectedData: ( data ) => {
348348
data.splice( 6, 4 );
349349
},
350350
expectedRangeOrSelection: new ve.Range( 6 ),
@@ -354,43 +354,39 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
354354
htmlOrDoc: '<p>foo</p>',
355355
rangeOrSelection: new ve.Range( 4 ),
356356
keys: [ 'DELETE' ],
357-
expectedData: function () {
358-
},
357+
expectedData: () => {},
359358
expectedRangeOrSelection: new ve.Range( 4 ),
360359
msg: 'Delete at end of last paragraph does nothing'
361360
},
362361
{
363362
htmlOrDoc: '<p>foo</p><p>bar</p><p></p>',
364363
rangeOrSelection: new ve.Range( 11 ),
365364
keys: [ 'DELETE' ],
366-
expectedData: function () {
367-
},
365+
expectedData: () => {},
368366
expectedRangeOrSelection: new ve.Range( 11 ),
369367
msg: 'Delete at end of last empty paragraph does nothing'
370368
},
371369
{
372370
htmlOrDoc: '<div rel="ve:Alien">foo</div><p>bar</p>',
373371
rangeOrSelection: new ve.Range( 2 ),
374372
keys: [ 'BACKSPACE' ],
375-
expectedData: function () {
376-
},
373+
expectedData: () => {},
377374
expectedRangeOrSelection: new ve.Range( 0, 2 ),
378375
msg: 'Backspace after an alien just selects it'
379376
},
380377
{
381378
htmlOrDoc: '<p>bar</p><div rel="ve:Alien">foo</div>',
382379
rangeOrSelection: new ve.Range( 4 ),
383380
keys: [ 'DELETE' ],
384-
expectedData: function () {
385-
},
381+
expectedData: () => {},
386382
expectedRangeOrSelection: new ve.Range( 5, 7 ),
387383
msg: 'Delete before an alien just selects it'
388384
},
389385
{
390386
htmlOrDoc: '<div rel="ve:Alien">foo</div><ul><li><p>bar</p></li></ul>',
391387
rangeOrSelection: new ve.Range( 5 ),
392388
keys: [ 'BACKSPACE' ],
393-
expectedData: function ( data ) {
389+
expectedData: ( data ) => {
394390
data.splice( 2, 2 );
395391
data.splice( 7, 2 );
396392
},
@@ -401,8 +397,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
401397
htmlOrDoc: '<p>baz</p><div rel="ve:Alien">foo</div><ul><li><p>bar</p></li></ul>',
402398
rangeOrSelection: new ve.Range( 10 ),
403399
keys: [ 'BACKSPACE' ],
404-
expectedData: function () {
405-
},
400+
expectedData: () => {},
406401
expectedRangeOrSelection: new ve.Range( 5, 7 ),
407402
// TODO: Make this more consistent with "List after an alien unwrapped by backspace"
408403
msg: 'List after an alien after content selects the alien'
@@ -411,7 +406,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
411406
htmlOrDoc: '<p></p><div rel="ve:Alien">foo</div>',
412407
rangeOrSelection: new ve.Range( 2, 4 ),
413408
keys: [ 'BACKSPACE' ],
414-
expectedData: function ( data ) {
409+
expectedData: ( data ) => {
415410
data.splice( 2, 2 );
416411
},
417412
expectedRangeOrSelection: new ve.Range( 1 ),
@@ -421,7 +416,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
421416
htmlOrDoc: '<p></p><div rel="ve:Alien">foo</div>',
422417
rangeOrSelection: new ve.Range( 2, 4 ),
423418
keys: [ 'DELETE' ],
424-
expectedData: function ( data ) {
419+
expectedData: ( data ) => {
425420
data.splice( 2, 2 );
426421
},
427422
expectedRangeOrSelection: new ve.Range( 1 ),
@@ -431,7 +426,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
431426
htmlOrDoc: '<div rel="ve:Alien">foo</div><div rel="ve:Alien">foo</div>',
432427
rangeOrSelection: new ve.Range( 2, 4 ),
433428
keys: [ 'BACKSPACE' ],
434-
expectedData: function ( data ) {
429+
expectedData: ( data ) => {
435430
data.splice( 2, 2 );
436431
},
437432
expectedRangeOrSelection: new ve.Range( 0 ),
@@ -441,7 +436,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
441436
htmlOrDoc: '<div rel="ve:Alien">foo</div><div rel="ve:Alien">foo</div>',
442437
rangeOrSelection: new ve.Range( 2, 4 ),
443438
keys: [ 'DELETE' ],
444-
expectedData: function ( data ) {
439+
expectedData: ( data ) => {
445440
data.splice( 2, 2 );
446441
},
447442
expectedRangeOrSelection: new ve.Range( 0 ),
@@ -451,7 +446,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
451446
htmlOrDoc: '<div rel="ve:Alien">foo</div>',
452447
rangeOrSelection: new ve.Range( 0, 2 ),
453448
keys: [ 'BACKSPACE' ],
454-
expectedData: function ( data ) {
449+
expectedData: ( data ) => {
455450
data.splice( 0, 2,
456451
{ type: 'paragraph' },
457452
{ type: '/paragraph' }
@@ -472,16 +467,15 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
472467
htmlOrDoc: link,
473468
rangeOrSelection: new ve.Range( 5 ),
474469
keys: [ 'DELETE' ],
475-
expectedData: function () {
476-
},
470+
expectedData: () => {},
477471
expectedRangeOrSelection: new ve.Range( 5 ),
478472
msg: 'Delete from outside a link just activates the link'
479473
},
480474
{
481475
htmlOrDoc: link,
482476
rangeOrSelection: new ve.Range( 6 ),
483477
keys: [ 'BACKSPACE', 'BACKSPACE' ],
484-
expectedData: function ( data ) {
478+
expectedData: ( data ) => {
485479
data.splice( 5, 1 );
486480
},
487481
expectedRangeOrSelection: new ve.Range( 5 ),
@@ -492,7 +486,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
492486
htmlOrDoc: link,
493487
rangeOrSelection: new ve.Range( 7 ),
494488
keys: [ 'DELETE', 'DELETE' ],
495-
expectedData: function ( data ) {
489+
expectedData: ( data ) => {
496490
data.splice( 7, 1 );
497491
},
498492
expectedRangeOrSelection: new ve.Range( 7 ),
@@ -503,7 +497,7 @@ QUnit.test( 'special key down: linear backspace/delete', ( assert ) => {
503497
htmlOrDoc: link,
504498
rangeOrSelection: new ve.Range( 8 ),
505499
keys: [ 'BACKSPACE', 'BACKSPACE', 'BACKSPACE', 'BACKSPACE', 'BACKSPACE' ],
506-
expectedData: function ( data ) {
500+
expectedData: ( data ) => {
507501
data.splice( 5, 3 );
508502
},
509503
expectedRangeOrSelection: new ve.Range( 5 ),

0 commit comments

Comments
 (0)