Deactivate/reactivate the surface when entering/leaving review mode

kemayo · kemayo · commit b5299e765928 · 2025-03-25T17:00:42.000-05:00
Bug: T389904
Change-Id: I9ab004802e6315a8137e17141dc1663b9b188d27
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
@@ -542,6 +542,9 @@ ve.ce.Surface.prototype.setReviewMode = function ( reviewMode, highlightNodes )
 		this.$element.find( '.ve-ce-surface-reviewMode-highlightNode' )
 			.removeClass( 've-ce-surface-reviewMode-highlightNode' );
 	}
+	if ( this.reviewMode ) {
+		this.deactivate( false );
+	}
 };
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -542,6 +542,9 @@ ve.ce.Surface.prototype.setReviewMode = function ( reviewMode, highlightNodes )`
`542`	`542`	`this.$element.find( '.ve-ce-surface-reviewMode-highlightNode' )`
`543`	`543`	`.removeClass( 've-ce-surface-reviewMode-highlightNode' );`
`544`	`544`	`}`
	`545`	`+ if ( this.reviewMode ) {`
	`546`	`+ this.deactivate( false );`
	`547`	`+ }`
`545`	`548`	`};`
`546`	`549`
`547`	`550`	`/**`