Skip to content

Commit 2b4c3f5

Browse files
committed
fix: JAVA_HOME leak in docker
1 parent 842975f commit 2b4c3f5

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

index.py

+4
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ def gen_golang_index():
3636

3737

3838
def gen_java_and_kotlin_index():
39+
# lock down JAVA_HOME
40+
# https://github.com/orgs/community/discussions/25738
41+
os.environ["JAVA_HOME"] = "/usr/lib/jvm/java-8-openjdk"
42+
3943
# https://sourcegraph.github.io/scip-java/docs/getting-started.html#run-scip-java-index
4044
check_call(["scip-java", "index", "--output", "index.scip"])
4145

main.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def dot_to_svg(dot_file):
161161

162162

163163
def sort_files_by_impact(
164-
files: typing.Iterable[FileMetrics],
164+
files: typing.Iterable[FileMetrics],
165165
) -> typing.List[FileMetrics]:
166166
def sort_key(f: FileMetrics):
167167
return f.impactLineCount

utils.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1+
import os
12
import subprocess
23
from loguru import logger
34

45

56
def check_call(commands: list):
67
logger.info(f"check calling: {commands}")
7-
subprocess.check_call(commands)
8+
subprocess.check_call(commands, env=os.environ)

0 commit comments

Comments
 (0)