Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to decide if new version is good #43

Open
fiunchinho opened this issue Apr 25, 2017 · 2 comments
Open

Script to decide if new version is good #43

fiunchinho opened this issue Apr 25, 2017 · 2 comments

Comments

@fiunchinho
Copy link
Collaborator

Wimpy could execute a shell script right after deploying the new version, and before deleting the old one.
This script could check error ratio in /metrics endpoint (or whatever logic is needed) to determine if the new version is good, and the old one can be removed.
The default script could just exit 0

@ismaelfernandezscmspain

Sounds good but isn't it trivial.
Do you want to reference only HTTP metrics or instance metrics too?
I think about instance metrics and is a bit difficult because is not the same measure it in the morning that in afternoon.

I like saying that you can have false positives.

@fiunchinho
Copy link
Collaborator Author

Playing around with Spring and some metrics library, we can an Spring application to show in the /metrics endpoint the HTTP error ratio for an application. The ratio should be similar through the day (since it's a ratio, not just a number).

Anyway, that's not something that wimpy should care about. The user would provide the script: wimpy just executes whatever the user has in her repository, and if the exit code is 0, the old CloudFormation is removed. If the exit code is 1, the old one is kept, and the new one is removed. The script could do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants