add unit test

Signed-off-by: win5923 <[email protected]>

Author: win5923

kubectl-plugin/pkg/cmd/job/job_submit_test.go

@@ -94,6 +94,25 @@ spec:
 				workingDir: "Fake/File/Path",
 			},
 		},
+		{
+			name: "TTLSecondsAfterFinished with shutdownAfterJobFinishes disabled should error",
+			opts: &SubmitJobOptions{
+				configFlags: &genericclioptions.ConfigFlags{
+					Namespace:        &testNS,
+					Context:          &testContext,
+					KubeConfig:       &kubeConfigWithCurrentContext,
+					BearerToken:      &testBT,
+					Impersonate:      &testImpersonate,
+					ImpersonateGroup: &[]string{"fake-group"},
+				},
+				ioStreams:                &testStreams,
+				fileName:                 rayJobYamlPath,
+				workingDir:               "Fake/File/Path",
+				shutdownAfterJobFinishes: false,
+				ttlSecondsAfterFinished:  100,
+			},
+			expectError: "TTLSecondsAfterFinished only working when ShutdownAfterJobFinishes set to true when ShutdownAfterJobFinishes is set to true",
+		},
 		{
 			name: "Successful submit job validation with RayJob",
 			opts: &SubmitJobOptions{
@@ -105,9 +124,11 @@ spec:
 					Impersonate:      &testImpersonate,
 					ImpersonateGroup: &[]string{"fake-group"},
 				},
-				ioStreams:  &testStreams,
-				fileName:   rayJobYamlPath,
-				workingDir: "Fake/File/Path",
+				ioStreams:                &testStreams,
+				fileName:                 rayJobYamlPath,
+				workingDir:               "Fake/File/Path",
+				shutdownAfterJobFinishes: true,
+				ttlSecondsAfterFinished:  100,
 			},
 		},
 	}

kubectl-plugin/pkg/util/generation/generation_test.go

@@ -50,9 +50,12 @@ func TestGenerateRayCluterApplyConfig(t *testing.T) {
 
 func TestGenerateRayJobApplyConfig(t *testing.T) {
 	testRayJobYamlObject := RayJobYamlObject{
-		RayJobName:     "test-ray-job",
-		Namespace:      "default",
-		SubmissionMode: "InteractiveMode",
+		RayJobName:               "test-ray-job",
+		Namespace:                "default",
+		SubmissionMode:           "InteractiveMode",
+		DeletionPolicy:           "DeleteCluster",
+		TTLSecondsAfterFinished:  100,
+		ShutdownAfterJobFinishes: true,
 		RayClusterSpecObject: RayClusterSpecObject{
 			RayVersion:     util.RayVersion,
 			Image:          util.RayImage,
@@ -80,6 +83,9 @@ func TestGenerateRayJobApplyConfig(t *testing.T) {
 	assert.Equal(t, testRayJobYamlObject.WorkerReplicas, *result.Spec.RayClusterSpec.WorkerGroupSpecs[0].Replicas)
 	assert.Equal(t, resource.MustParse(testRayJobYamlObject.WorkerCPU), *result.Spec.RayClusterSpec.WorkerGroupSpecs[0].Template.Spec.Containers[0].Resources.Requests.Cpu())
 	assert.Equal(t, resource.MustParse(testRayJobYamlObject.WorkerMemory), *result.Spec.RayClusterSpec.WorkerGroupSpecs[0].Template.Spec.Containers[0].Resources.Requests.Memory())
+	assert.Equal(t, rayv1.DeletionPolicy(testRayJobYamlObject.DeletionPolicy), *result.Spec.DeletionPolicy)
+	assert.Equal(t, testRayJobYamlObject.TTLSecondsAfterFinished, *result.Spec.TTLSecondsAfterFinished)
+	assert.Equal(t, testRayJobYamlObject.ShutdownAfterJobFinishes, *result.Spec.ShutdownAfterJobFinishes)
 }
 
 func TestConvertRayClusterApplyConfigToYaml(t *testing.T) {