Skip to content

Commit 6d22faf

Browse files
authored
fix: add accessibility labels - WPB-16078 (#2574)
1 parent 62df1ee commit 6d22faf

File tree

4 files changed

+9
-1
lines changed

4 files changed

+9
-1
lines changed

WireUI/Sources/WireSettingsUI/Account/BackupImportExport/Export/SetBackupBasswordView/SetBackupPasswordView.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ struct SetBackupPasswordView: View {
6464
.disabled(!viewModel.isPasswordValid)
6565
.wireButtonStyle(.primary)
6666
.padding()
67+
.accessibilityIdentifier("back up now")
6768
}
6869
}
6970

WireUI/Sources/WireSettingsUI/Account/BackupImportExport/Import/EnterPasswordView/EnterPasswordView.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ struct EnterPasswordView: View {
2323

2424
@Binding var password: String
2525
@Binding var passwordIsWrong: Bool
26+
var focusPasswordFieldOnAppear = true
2627

2728
let continueAction: (_ password: String) -> Void
2829
let cancelAction: () -> Void
@@ -89,7 +90,7 @@ struct EnterPasswordView: View {
8990
password: $password,
9091
placeholder: Strings.EnterPassword.TextField.placeholder,
9192
placeholderColor: passwordFieldPlaceholderColor,
92-
focusOnAppear: true
93+
focusOnAppear: focusPasswordFieldOnAppear
9394
)
9495
.tint(passwordFieldBorderColor)
9596
.padding(.bottom, 8)

WireUI/Sources/WireSettingsUI/Account/BackupImportExport/Misc/ToggleablePasswordField.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ struct ToggleablePasswordField: View {
8181
.textContentType(.password)
8282
.autocapitalization(.none)
8383
.focused($focusedField, equals: .textField)
84+
.accessibilityIdentifier("password input")
8485
}
8586

8687
@ViewBuilder private var secureField: some View {
@@ -91,6 +92,7 @@ struct ToggleablePasswordField: View {
9192
}
9293
.textContentType(.password)
9394
.focused($focusedField, equals: .secureField)
95+
.accessibilityIdentifier("password input")
9496
}
9597

9698
private var toggleButtonAccessibilityLabel: String {

WireUI/Tests/WireSettingsUITests/Account/BackupImportExport/Import/EnterPasswordViewSnapshotTests.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ final class EnterPasswordViewSnapshotTests: XCTestCase {
4141
let sut = EnterPasswordView(
4242
password: .constant("invalid"),
4343
passwordIsWrong: .constant(true),
44+
focusPasswordFieldOnAppear: false,
4445
continueAction: { _ in },
4546
cancelAction: {}
4647
)
@@ -59,6 +60,7 @@ final class EnterPasswordViewSnapshotTests: XCTestCase {
5960
let sut = EnterPasswordView(
6061
password: .constant("G00dPassword!"),
6162
passwordIsWrong: .constant(false),
63+
focusPasswordFieldOnAppear: false,
6264
continueAction: { _ in },
6365
cancelAction: {}
6466
)
@@ -77,6 +79,7 @@ final class EnterPasswordViewSnapshotTests: XCTestCase {
7779
let sut = EnterPasswordView(
7880
password: .constant(""),
7981
passwordIsWrong: .constant(false),
82+
focusPasswordFieldOnAppear: false,
8083
continueAction: { _ in },
8184
cancelAction: {}
8285
)
@@ -92,6 +95,7 @@ final class EnterPasswordViewSnapshotTests: XCTestCase {
9295
let sut = EnterPasswordView(
9396
password: .constant(""),
9497
passwordIsWrong: .constant(false),
98+
focusPasswordFieldOnAppear: false,
9599
continueAction: { _ in },
96100
cancelAction: {}
97101
)

0 commit comments

Comments
 (0)