Skip to content

Commit ce0227d

Browse files
fix: remove unnecessary width and height settings for modal dialog and clean up iOS keyboard handling
1 parent a5b0f78 commit ce0227d

File tree

5 files changed

+2
-20
lines changed

5 files changed

+2
-20
lines changed

packages/ckeditor5/dist/browser/index.js

Lines changed: 0 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/ckeditor5/dist/browser/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/ckeditor5/dist/browser/index.umd.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7880,8 +7880,6 @@
78807880
/**
78817881
* Sets the modal dialog initial size.
78827882
*/ recalculateSize() {
7883-
this.wrapper.style.width = `${this.container.clientWidth - 12}px`;
7884-
this.wrapper.style.height = `${this.container.clientHeight - 38}px`;
78857883
this.contentContainer.style.height = `${parseInt(this.wrapper.offsetHeight - 50, 10)}px`;
78867884
}
78877885
/**
@@ -8289,10 +8287,8 @@
82898287
if (!this.iosSoftkeyboardOpened && this.iosDivHeight != null && this.iosDivHeight === `auto`) {
82908288
if (this.portraitMode()) {
82918289
this.setContainerHeight(`60${this.iosMeasureUnit}`);
8292-
this.wrapper.style.flexGrow = "unset";
82938290
} else {
82948291
this.setContainerHeight(`35${this.iosMeasureUnit}`);
8295-
this.wrapper.style.flexGrow = "unset";
82968292
}
82978293
}
82988294
this.iosSoftkeyboardOpened = true;
@@ -8310,10 +8306,8 @@
83108306
if (this.iosSoftkeyboardOpened) {
83118307
if (this.portraitMode()) {
83128308
this.setContainerHeight(`65${this.iosMeasureUnit}`);
8313-
this.wrapper.style.flexGrow = "unset";
83148309
} else {
83158310
this.setContainerHeight(`45${this.iosMeasureUnit}`);
8316-
this.wrapper.style.flexGrow = "unset";
83178311
}
83188312
} else {
83198313
this.wrapper.style.flexGrow = "1";

packages/ckeditor5/dist/browser/index.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/devkit/src/modal.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -972,8 +972,6 @@ export default class ModalDialog {
972972
* Sets the modal dialog initial size.
973973
*/
974974
recalculateSize() {
975-
this.wrapper.style.width = `${this.container.clientWidth - 12}px`;
976-
this.wrapper.style.height = `${this.container.clientHeight - 38}px`;
977975
this.contentContainer.style.height = `${parseInt(this.wrapper.offsetHeight - 50, 10)}px`;
978976
}
979977

@@ -1444,10 +1442,8 @@ export default class ModalDialog {
14441442
) {
14451443
if (this.portraitMode()) {
14461444
this.setContainerHeight(`60${this.iosMeasureUnit}`);
1447-
this.wrapper.style.flexGrow = "unset";
14481445
} else {
14491446
this.setContainerHeight(`35${this.iosMeasureUnit}`);
1450-
this.wrapper.style.flexGrow = "unset";
14511447
}
14521448
}
14531449
this.iosSoftkeyboardOpened = true;
@@ -1469,11 +1465,9 @@ export default class ModalDialog {
14691465
if (this.iosSoftkeyboardOpened) {
14701466
if (this.portraitMode()) {
14711467
this.setContainerHeight(`65${this.iosMeasureUnit}`);
1472-
this.wrapper.style.flexGrow = "unset";
14731468

14741469
} else {
14751470
this.setContainerHeight(`45${this.iosMeasureUnit}`);
1476-
this.wrapper.style.flexGrow = "unset";
14771471

14781472
}
14791473
} else {

0 commit comments

Comments
 (0)