Update log4j version

Author: Ruben Nogueroles

.gitignore

@@ -1,5 +1,6 @@
 /target/
 */target/**
+files/
 /test-output/
 */test-output/**
 .DS_Store

pom.xml

@@ -32,7 +32,7 @@
 		<maven-compiler-plugin.version>3.8.0</maven-compiler-plugin.version>
 		<testng.version>6.14.2</testng.version>
 		<commons.lang3.version>3.12.0</commons.lang3.version>
-		<log4j.version>1.2.17</log4j.version>
+		<log4j.version>2.18.0</log4j.version>
 		<commons-io.version>2.4</commons-io.version>
 		<aspectj.version>1.9.9.1</aspectj.version>
 
@@ -68,10 +68,15 @@
             <artifactId>commons-lang3</artifactId>
             <version>${commons.lang3.version}</version>
         </dependency>
-        <dependency>
-			<groupId>log4j</groupId>
-			<artifactId>log4j</artifactId>
-			<version>${log4j.version}</version>
+		<dependency>
+		    <groupId>org.apache.logging.log4j</groupId>
+		    <artifactId>log4j-api</artifactId>
+		    <version>${log4j.version}</version>
+		</dependency>
+		<dependency>
+		    <groupId>org.apache.logging.log4j</groupId>
+		    <artifactId>log4j-core</artifactId>
+		    <version>${log4j.version}</version>
 		</dependency>	
 		<!-- https://mvnrepository.com/artifact/org.aspectj/aspectjweaver -->
 		<dependency>

src/main/java/com/wizeline/selenium/drivers/BaseWebDriverUtil.java

@@ -12,7 +12,8 @@
 import java.util.List;
 
 import org.apache.commons.io.FileUtils;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.openqa.selenium.By;
 import org.openqa.selenium.JavascriptExecutor;
 import org.openqa.selenium.OutputType;
@@ -23,12 +24,13 @@
 import org.openqa.selenium.support.ui.ExpectedConditions;
 import org.openqa.selenium.support.ui.WebDriverWait;
 
+
 import com.wizeline.selenium.utils.Initialization;
 
 
 public class BaseWebDriverUtil {
 
-    private static Logger log = Logger.getLogger(BaseWebDriverUtil.class);
+    private static Logger log = LogManager.getLogger(BaseWebDriverUtil.class);
 
     // **** Basic operation methods section ****//
     /**
@@ -42,19 +44,25 @@ public class BaseWebDriverUtil {
      *         case
      */
     public static boolean existsElement(BaseWebDriver driver, By selector) {
-        log.info(
+        
+    	
+    	log.info(
                 "[log-Utils] BaseWebDriverUtil - Start existsElement method");
 
         boolean exists = false;
 
         try {
             exists = (driver.findElement(selector) != null);
+            
+            
         } catch (Exception ex) {
             exists = false;
         }
-
+        
         log.info("[log-Utils] BaseWebDriverUtil - End existsElement method");
 
+        
+
         return exists;
     }
 

src/main/java/com/wizeline/selenium/testSets/DefaultTestSet.java

@@ -3,7 +3,8 @@
 import java.io.File;
 import java.lang.reflect.Method;
 
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.testng.Assert;
 import org.testng.ITestResult;
 import org.testng.annotations.AfterMethod;
@@ -29,8 +30,8 @@ public class DefaultTestSet {
     //PageObjetc instances
     protected LandingPage landingPage;
     protected ResultsPage resultsPage;
-
-    protected static Logger log = Logger.getLogger(DefaultTestSet.class);
+    
+    private static Logger log = LogManager.getLogger(DefaultTestSet.class);
 
     @BeforeClass(description = "beforeClassMethod")
     public void beforeClass() {

src/main/java/com/wizeline/selenium/utils/Initialization.java

@@ -7,8 +7,8 @@
 import java.util.Properties;
 
 import org.apache.commons.io.FileUtils;
-import org.apache.log4j.Logger;
-
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.openqa.selenium.chrome.ChromeOptions;
 import org.openqa.selenium.firefox.FirefoxOptions;
 import org.openqa.selenium.firefox.FirefoxProfile;
@@ -17,7 +17,6 @@
 import com.wizeline.selenium.drivers.CustomChromeDriver;
 import com.wizeline.selenium.drivers.CustomFirefoxDriver;
 
-
 public class Initialization {
 
     private String properties;
@@ -33,7 +32,8 @@ public class Initialization {
     private int heightBeforeMaximize;
     private int heightAfterMaximize;
     private static Initialization instance = null;
-    private static Logger log = Logger.getLogger(Initialization.class);
+    
+    private static Logger log = LogManager.getLogger(Initialization.class);
 
     BaseWebDriver driver;
 
@@ -63,7 +63,7 @@ public void readProperties() {
 
         properties = "test.properties";
         Properties prop = new Properties();
-        log = Logger.getLogger(this.getClass());
+        //log = Logger.getLogger(this.getClass());
 
         try {
             ClassLoader loader = Thread.currentThread().getContextClassLoader();
@@ -243,7 +243,7 @@ public void cleanDownloadDirectory() {
             try {
                 FileUtils.cleanDirectory(f);
             } catch (IOException e) {
-                log.error(e.getStackTrace());
+                log.error(e.getStackTrace().toString());
             }
         }
     }

src/main/resources/log4j.properties

@@ -0,0 +1,16 @@
+# Extra logging related to initialization of Log4j
+# Set to info or trace if log4j initialization is failing
+status = warn
+# Name of the configuration
+name = ConsoleLogConfigDemo
+
+# Console appender configuration
+appender.console.type = Console
+appender.console.name = consoleLogger
+appender.console.layout.type = PatternLayout
+appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss} %-5p %c{1}:%L - %m%n
+
+# Root logger level
+rootLogger.level = INFO
+# Root logger referring to console appender
+rootLogger.appenderRef.stdout.ref = consoleLogger