Skip to content

Commit 831e77a

Browse files
committed
implement minor changes requested
1 parent ecefa69 commit 831e77a

File tree

9 files changed

+17
-21
lines changed

9 files changed

+17
-21
lines changed

docker_compose_test/docker-compose.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ services:
55
- test.env
66
build:
77
context: ./../
8-
dockerfile: Dockerfile
98
depends_on:
109
elasticsearch:
1110
condition: service_healthy

docker_compose_test/requirements.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
requests
21
paho-mqtt
3-
pytest
2+
pytest
3+
requests

docker_compose_test/tests/integration/test_wis2box.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,10 @@
2323
# .github/workflows/wis2box_test.yml has been executed
2424

2525
import json
26+
import os
2627
import time
28+
2729
import requests
28-
import os
2930

3031
import paho.mqtt.client as mqtt
3132

@@ -90,11 +91,8 @@ def transform_to_bufr(process_name: str,
9091
response = requests.get(f'{job_location_url}/results?f=json', headers=headers) # noqa
9192
response_json = response.json()
9293
# print(response_json)
93-
assert response_json['result'] == expected_response['result']
94-
assert response_json['messages transformed'] == expected_response['messages transformed'] # noqa
95-
assert response_json['messages published'] == expected_response['messages published'] # noqa
96-
assert response_json['errors'] == expected_response['errors']
97-
assert response_json['warnings'] == expected_response['warnings']
94+
for key in ['result', 'messages transformed', 'messages published', 'errors', 'warnings']: # noqa
95+
assert response_json[key] == expected_response[key]
9896

9997
filename = data['inputs']['channel'].replace('/', '_') + '.json'
10098

@@ -118,10 +116,8 @@ def transform_to_bufr(process_name: str,
118116
}
119117

120118
# compare the received message with the expected message
121-
assert message['channel'] == expected_message['channel']
122-
assert message['filename'] == expected_message['filename']
123-
assert message['data'] == expected_message['data']
124-
assert message['_meta'] == expected_message['_meta']
119+
for key in ['channel', 'filename', 'data', '_meta']:
120+
assert message[key] == expected_message[key]
125121

126122

127123
def test_synop2bufr():

wis2box_api/admin.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
from copy import deepcopy
2323
import os
2424
import json
25+
2526
import json_merge_patch
2627
from jsonschema.exceptions import ValidationError
2728
import logging

wis2box_api/plugins/process/bufr2bufr.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,13 @@
1919
#
2020
###############################################################################
2121

22-
import logging
2322
import base64
23+
import logging
2424

2525
from pygeoapi.process.base import BaseProcessor
2626

2727
from wis2box_api.wis2box.handle import handle_error
2828
from wis2box_api.wis2box.handle import DataHandler
29-
3029
from wis2box_api.wis2box.bufr4 import ObservationDataBUFR
3130

3231
LOGGER = logging.getLogger(__name__)

wis2box_api/plugins/process/bufr2geojson.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@
1919
#
2020
###############################################################################
2121

22+
import base64
2223
import logging
24+
2325
import requests
24-
import base64
2526

2627
from pygeoapi.process.base import BaseProcessor
2728
from bufr2geojson import transform as as_geojson

wis2box_api/plugins/process/csv2bufr.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919
#
2020
###############################################################################
2121

22+
import json
2223
import logging
24+
import os
2325

2426
from pygeoapi.process.base import BaseProcessor
2527

@@ -31,9 +33,6 @@
3133

3234
from csv2bufr import transform as transform_csv
3335

34-
import json
35-
import os
36-
3736
LOGGER = logging.getLogger(__name__)
3837

3938
PROCESS_METADATA = {

wis2box_api/wis2box/bufr4.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,11 @@
1919
#
2020
###############################################################################
2121

22-
from datetime import datetime
2322
import logging
2423
import tempfile
2524

25+
from datetime import datetime
26+
2627
from bufr2geojson import BUFRParser
2728
from eccodes import (
2829
codes_bufr_copy_data,

wis2box_api/wis2box/station.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
# under the License.
1919
#
2020
###############################################################################
21-
import csv
2221

22+
import csv
2323
import io
2424
import logging
2525

0 commit comments

Comments
 (0)