Skip to content
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

Commit 25c8314

Browse files
author
William Monk
committed
Fix Code Review
1 parent 7419138 commit 25c8314

File tree

6 files changed

+20
-51
lines changed

6 files changed

+20
-51
lines changed

.github/ISSUE_TEMPLATE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
1. `node -v`:
8383
2. `npm -v`:
8484
4. `yarn --version` (if you use Yarn):
85-
3. `npm ls react-scripts` (if you haven’t ejected):
85+
3. `npm ls react-scripts-ts` (if you haven’t ejected):
8686

8787
Then, specify:
8888

packages/react-scripts/config/webpack.config.dev.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@ module.exports = {
100100
'.ts',
101101
'.web.tsx',
102102
'.tsx',
103+
'.web.js',
103104
'.js',
104105
'.json',
105-
'.jsx',
106106
'.web.jsx',
107107
'.jsx',
108108
],

packages/react-scripts/config/webpack.config.prod.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@ module.exports = {
100100
'.ts',
101101
'.web.tsx',
102102
'.tsx',
103+
'.web.js',
103104
'.js',
104105
'.json',
105-
'.jsx',
106106
'.web.jsx',
107107
'.jsx',
108108
],

packages/react-scripts/package.json

+6-38
Original file line numberDiff line numberDiff line change
@@ -22,68 +22,36 @@
2222
"react-scripts-ts": "./bin/react-scripts-ts.js"
2323
},
2424
"dependencies": {
25-
<<<<<<< HEAD
26-
"autoprefixer": "7.1.0",
27-
"app-root-path": "^2.0.1",
28-
"case-sensitive-paths-webpack-plugin": "2.0.0",
29-
"chalk": "1.1.3",
30-
"cli-highlight": "1.1.4",
31-
"css-loader": "0.28.1",
32-
"dotenv": "4.0.0",
33-
"extract-text-webpack-plugin": "2.1.0",
34-
"file-loader": "0.11.1",
35-
=======
3625
"autoprefixer": "7.1.1",
37-
"babel-core": "6.25.0",
38-
"babel-eslint": "7.2.3",
39-
"babel-jest": "20.0.3",
40-
"babel-loader": "7.0.0",
41-
"babel-preset-react-app": "^3.0.1",
42-
"babel-runtime": "6.23.0",
26+
"app-root-path": "^2.0.1",
4327
"case-sensitive-paths-webpack-plugin": "2.1.1",
4428
"chalk": "1.1.3",
29+
"chalk": "1.1.3",
30+
"cli-highlight": "1.1.4",
4531
"css-loader": "0.28.4",
4632
"dotenv": "4.0.0",
47-
"eslint": "3.19.0",
48-
"eslint-config-react-app": "^1.0.5",
49-
"eslint-loader": "1.7.1",
50-
"eslint-plugin-flowtype": "2.34.0",
51-
"eslint-plugin-import": "2.2.0",
52-
"eslint-plugin-jsx-a11y": "5.0.3",
53-
"eslint-plugin-react": "7.1.0",
5433
"extract-text-webpack-plugin": "2.1.2",
5534
"file-loader": "0.11.2",
56-
>>>>>>> c1221eb
5735
"fs-extra": "3.0.1",
5836
"html-webpack-plugin": "2.29.0",
5937
"jest": "20.0.4",
6038
"object-assign": "4.1.1",
6139
"postcss-flexbugs-fixes": "3.0.0",
6240
"postcss-loader": "2.0.6",
6341
"promise": "7.1.1",
64-
<<<<<<< HEAD
65-
"react-dev-utils": "^2.0.1",
66-
"react-error-overlay": "^1.0.6",
67-
"style-loader": "0.17.0",
42+
"react-dev-utils": "^3.0.1",
43+
"react-error-overlay": "^1.0.8",
44+
"style-loader": "0.18.2",
6845
"ts-loader": "^2.2.1",
6946
"tslint": "^5.2.0",
7047
"tslint-loader": "^3.5.3",
7148
"tslint-react": "^3.0.0",
7249
"typescript": "~2.4.0",
7350
"source-map-loader": "^0.2.1",
74-
"sw-precache-webpack-plugin": "0.9.1",
75-
"url-loader": "0.5.8",
76-
"webpack": "2.6.0",
77-
"webpack-dev-server": "2.4.5",
78-
=======
79-
"react-dev-utils": "^3.0.1",
80-
"react-error-overlay": "^1.0.8",
81-
"style-loader": "0.18.2",
8251
"sw-precache-webpack-plugin": "0.11.3",
8352
"url-loader": "0.5.9",
8453
"webpack": "2.6.1",
8554
"webpack-dev-server": "2.5.0",
86-
>>>>>>> c1221eb
8755
"webpack-manifest-plugin": "1.1.0",
8856
"whatwg-fetch": "2.0.3"
8957
},

packages/react-scripts/scripts/utils/createJestConfig.js

+11-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,17 @@ module.exports = (resolve, rootDir) => {
2727
collectCoverageFrom: ['src/**/*.{js,jsx,ts,tsx}'],
2828
setupFiles: [resolve('config/polyfills.js')],
2929
setupTestFrameworkScriptFile: setupTestsFile,
30-
moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'json'],
30+
moduleFileExtensions: [
31+
'web.ts',
32+
'ts',
33+
'web.tsx',
34+
'tsx',
35+
'web.js',
36+
'js',
37+
'web.jsx',
38+
'jsx',
39+
'json',
40+
],
3141
testMatch: [
3242
'<rootDir>/src/**/__tests__/**/*.ts?(x)',
3343
'<rootDir>/src/**/?(*.)(spec|test).ts?(x)',
@@ -45,7 +55,6 @@ module.exports = (resolve, rootDir) => {
4555
moduleNameMapper: {
4656
'^react-native$': 'react-native-web',
4757
},
48-
moduleFileExtensions: ['web.js', 'js', 'json', 'web.jsx', 'jsx'],
4958
};
5059
if (rootDir) {
5160
config.rootDir = rootDir;

packages/react-scripts/template/src/index.js

-8
This file was deleted.

0 commit comments

Comments
 (0)