It seems to me that in the following code snippet
|
for (Map.Entry<String, List<String>> entry : bucketIntroducers.entrySet()) { |
|
List<String> introducers = entry.getValue(); |
|
List<String> issues = bucketIssues.get(entry.getKey()); |
|
|
|
RevisionCombinationGenerator gen = new RevisionCombinationGenerator(introducers, issues, 2); |
|
gen = gen.iterator(); |
|
|
|
while(gen.hasNext()) { |
|
String[] pair = gen.getNextIndic(); |
|
if (pair[0] == "" && pair[1] == "") |
|
continue; |
|
|
|
if (isWithinTimeframe(pair[1], pair[0])) { |
|
bugIntroducers.add(pair); |
|
} else { |
|
|
|
if (!partialIntroducers.containsKey(entry.getKey())) { |
|
partialIntroducers.put(entry.getKey(), new ArrayList<>()); |
|
} |
|
partialIntroducers.get(entry.getKey()).add(pair[0]); |
|
|
|
if (!partialIssues.containsKey(entry.getKey())) { |
|
partialIssues.put(entry.getKey(), new ArrayList<>()); |
|
} |
|
partialIssues.get(entry.getKey()).add(pair[1]); |
|
} |
|
} |
|
} |
pair[0] is a bug-introducing commit, and pair[1] is a bug-fixing commit as defined in the issue list.
However, in line 193 (as well as in line 224), I think the order of the pair should be (bug-fixing commit, bug-introducing commit), so (pair[1], pair[0]).
Is this correct or am I missing something?
It seems to me that in the following code snippet
SZZUnleashed/szz/src/main/java/heuristics/SimpleBugIntroducerFinder.java
Lines 180 to 207 in 79f369f
pair[0]is a bug-introducing commit, andpair[1]is a bug-fixing commit as defined in the issue list.However, in line 193 (as well as in line 224), I think the order of the pair should be
(bug-fixing commit, bug-introducing commit), so(pair[1], pair[0]).Is this correct or am I missing something?