KeystoneTokenProvider is not checking for token expiration.

[mhshams]

Each token has an expire date, so token provider must check if the current token is expired or not.

this code in KeystoneTokenProvider:

public Access getAccessByTenant(String tenantName) {
        Access access = hashTenantAccess.get(tenantName);
        if (access == null) {  
            //code omitted. (request for new token)
        }
        return access;
}

must be something like:

public Access getAccessByTenant(String tenantName) {
        Access access = hashTenantAccess.get(tenantName);
        if (access == null  || Calendar.getInstance().after(access.getToken().getExpires())) {  
                       //code omitted. (request for new token)
        }
        return access;
}

[hossbert]

Did you manage to figure this out? It would nice to get a sample on how to handle tokens.

[mhshams]

@hossbert The second code fragment, in the issue, is the sample you are looking for. basically, in addition to check against null values, we need to check the token expiration too:

public Access getAccessByTenant(String tenantName) {
        Access access = hashTenantAccess.get(tenantName);
        if (access == null  || Calendar.getInstance().after(access.getToken().getExpires())) {  
                       //code omitted. (request for new token)
        }
        return access;
}

[hossbert]

Any chance of this getting merged into the main codebase?
On 31 May 2014 10:48, "Mohammad Shamsi" [email protected] wrote:

@hossbert https://github.com/hossbert The second code fragment, in the
issue, is the sample you are looking for. basically, in addition to check
against null values, we need to check the token expiration too:

public Access getAccessByTenant(String tenantName) {
Access access = hashTenantAccess.get(tenantName);
if (access == null || Calendar.getInstance().after(access.getToken().getExpires())) {
//code omitted. (request for new token)
}
return access;
}

—
Reply to this email directly or view it on GitHub
#129 (comment)
.