fix hlrad crashing on created BSP models

don't know why it happens but this fixed it

Author: wootguy

src/bsp/Bsp.cpp

@@ -5007,25 +5007,18 @@ void Bsp::create_node_box(vec3 min, vec3 max, BSPMODEL* targetModel, int texture
 	// add new edges (minimum needed to refrence every vertex once)
 	int startEdge = edgeCount;
 	{
-		BSPEDGE* newEdges = new BSPEDGE[edgeCount + 4];
+		BSPEDGE* newEdges = new BSPEDGE[edgeCount + 8];
 		memcpy(newEdges, edges, edgeCount * sizeof(BSPEDGE));
 
-		newEdges[startEdge + 0] = BSPEDGE(startVert + 0, startVert + 1);
-		newEdges[startEdge + 1] = BSPEDGE(startVert + 2, startVert + 3);
-		newEdges[startEdge + 2] = BSPEDGE(startVert + 4, startVert + 5);
-		newEdges[startEdge + 3] = BSPEDGE(startVert + 6, startVert + 7);
+		// defining an edge for every vertex because otherwise hlrad crashes, even though
+		// only 4 edges are required to reference every vertex on the cube
+		for (int i = 0; i < 8; i++) {
+			newEdges[startEdge + i] = BSPEDGE(startVert + i, startVert + i);
+		}
 
-		replace_lump(LUMP_EDGES, newEdges, (edgeCount + 4) * sizeof(BSPEDGE));
+		replace_lump(LUMP_EDGES, newEdges, (edgeCount + 8) * sizeof(BSPEDGE));
 	}
 
-	// maps a vertex number to a surfedge value
-	int32_t vertToSurfEdge[8] = {
-		(startEdge + 0), -(startEdge + 0), // negative value = use 2nd vertex in edge struct
-		(startEdge + 1), -(startEdge + 1),
-		(startEdge + 2), -(startEdge + 2),
-		(startEdge + 3), -(startEdge + 3),
-	};
-
 	// add new surfedges (vertex lookups into edges which define the faces, 4 per face, clockwise order)
 	int startSurfedge = surfedgeCount;
 	{
@@ -5035,40 +5028,40 @@ void Bsp::create_node_box(vec3 min, vec3 max, BSPMODEL* targetModel, int texture
 		int32_t surfEdgeIdx = startSurfedge;
 
 		// left face
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[7];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[4];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[0];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[3];
+		newSurfedges[surfEdgeIdx++] = startEdge + 7;
+		newSurfedges[surfEdgeIdx++] = startEdge + 4;
+		newSurfedges[surfEdgeIdx++] = startEdge + 0;
+		newSurfedges[surfEdgeIdx++] = startEdge + 3;
 
 		// right face
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[5];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[6];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[2];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[1];
+		newSurfedges[surfEdgeIdx++] = startEdge + 5;
+		newSurfedges[surfEdgeIdx++] = startEdge + 6;
+		newSurfedges[surfEdgeIdx++] = startEdge + 2;
+		newSurfedges[surfEdgeIdx++] = startEdge + 1;
 
 		// front face
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[4];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[5];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[1];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[0];
+		newSurfedges[surfEdgeIdx++] = startEdge + 4;
+		newSurfedges[surfEdgeIdx++] = startEdge + 5;
+		newSurfedges[surfEdgeIdx++] = startEdge + 1;
+		newSurfedges[surfEdgeIdx++] = startEdge + 0;
 
 		// back face
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[6];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[7];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[3];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[2];
+		newSurfedges[surfEdgeIdx++] = startEdge + 6;
+		newSurfedges[surfEdgeIdx++] = startEdge + 7;
+		newSurfedges[surfEdgeIdx++] = startEdge + 3;
+		newSurfedges[surfEdgeIdx++] = startEdge + 2;
 
 		// bottom face
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[0];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[1];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[2];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[3];
+		newSurfedges[surfEdgeIdx++] = startEdge + 0;
+		newSurfedges[surfEdgeIdx++] = startEdge + 1;
+		newSurfedges[surfEdgeIdx++] = startEdge + 2;
+		newSurfedges[surfEdgeIdx++] = startEdge + 3;
 
 		// top face
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[7];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[6];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[5];
-		newSurfedges[surfEdgeIdx++] = vertToSurfEdge[4];
+		newSurfedges[surfEdgeIdx++] = startEdge + 7;
+		newSurfedges[surfEdgeIdx++] = startEdge + 6;
+		newSurfedges[surfEdgeIdx++] = startEdge + 5;
+		newSurfedges[surfEdgeIdx++] = startEdge + 4;
 
 		replace_lump(LUMP_SURFEDGES, newSurfedges, (surfedgeCount + 24) * sizeof(int32_t));
 	}