Skip to content

Commit 80131af

Browse files
ravishankerravishanker
committed
Merge remote-tracking branch 'origin/release/18.8' into feature/15609-add-tracks
2 parents bfe1f54 + 259a61b commit 80131af

File tree

11 files changed

+64
-30
lines changed

11 files changed

+64
-30
lines changed

‎RELEASE-NOTES.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
*** PLEASE FOLLOW THIS FORMAT: [<priority indicator, more stars = higher priority>] <description> [<PR URL>]
22

3+
18.9
4+
-----
5+
6+
37
18.8
48
-----
59
* [*] Users can now upload files to forms when using the Preview within the editor. [https://github.com/wordpress-mobile/WordPress-Android/pull/15572]

‎WordPress/jetpack_metadata/release_notes.txt

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,12 @@
1-
- We expanded the "Link To" setting for the image block to include "Media File" and "Attachment Page" options alongside the preexisting "Custom URL" option.
2-
- We solved a problem with content autosaves so they now run more smoothly.
1+
* [*] Users can now upload files to forms when using the Preview within the editor. [https://github.com/wordpress-mobile/WordPress-Android/pull/15572]
2+
* [**] Posts List: Adds copy post link functionality [https://github.com/wordpress-mobile/WordPress-Android/pull/15570]
3+
* [*] Editor: Replace snackbar with compact notice when switching between HTML or Visual mode [https://github.com/wordpress-mobile/WordPress-Android/pull/15583]
4+
* [*] Fixed an issue where multiple screens were rendered incorrectly in RTL interface languages [https://github.com/wordpress-mobile/WordPress-Android/pull/15597]
5+
* [*] Updated UI of post comments [https://github.com/wordpress-mobile/WordPress-Android/pull/15595]
6+
* [**] Block editor: Add clipboard link suggestion to image block and button block. [https://github.com/WordPress/gutenberg/pull/35972]
7+
* [*] Block editor: Embed block: Include link in block settings. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4189]
8+
* [**] Block editor: Fix tab titles translation of inserter menu. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4248]
9+
* [**] Block editor: Gallery block: When a gallery block is added, the media options are auto opened for v2 of the Gallery block. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4277]
10+
* [*] Block editor: Media & Text block: Fix an issue where the text font size would be bigger than expected in some cases. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4252]
11+
12+

‎WordPress/metadata/release_notes.txt

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,12 @@
1-
- We expanded the "Link To" setting for the image block to include "Media File" and "Attachment Page" options alongside the preexisting "Custom URL" option.
2-
- We solved a problem with content autosaves so they now run more smoothly.
1+
* [*] Users can now upload files to forms when using the Preview within the editor. [https://github.com/wordpress-mobile/WordPress-Android/pull/15572]
2+
* [**] Posts List: Adds copy post link functionality [https://github.com/wordpress-mobile/WordPress-Android/pull/15570]
3+
* [*] Editor: Replace snackbar with compact notice when switching between HTML or Visual mode [https://github.com/wordpress-mobile/WordPress-Android/pull/15583]
4+
* [*] Fixed an issue where multiple screens were rendered incorrectly in RTL interface languages [https://github.com/wordpress-mobile/WordPress-Android/pull/15597]
5+
* [*] Updated UI of post comments [https://github.com/wordpress-mobile/WordPress-Android/pull/15595]
6+
* [**] Block editor: Add clipboard link suggestion to image block and button block. [https://github.com/WordPress/gutenberg/pull/35972]
7+
* [*] Block editor: Embed block: Include link in block settings. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4189]
8+
* [**] Block editor: Fix tab titles translation of inserter menu. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4248]
9+
* [**] Block editor: Gallery block: When a gallery block is added, the media options are auto opened for v2 of the Gallery block. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4277]
10+
* [*] Block editor: Media & Text block: Fix an issue where the text font size would be bigger than expected in some cases. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4252]
11+
12+

‎WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/granular/usecases/AuthorsUseCase.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.ListI
2929
import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.ListItemWithIcon.IconStyle.EMPTY_SPACE
3030
import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.ListItemWithIcon.IconStyle.NORMAL
3131
import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.ListItemWithIcon.TextStyle.LIGHT
32-
import org.wordpress.android.ui.utils.ListItemInteraction.Companion.create
3332
import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.Title
3433
import org.wordpress.android.ui.stats.refresh.lists.sections.granular.GranularStatefulUseCase
3534
import org.wordpress.android.ui.stats.refresh.lists.sections.granular.GranularUseCaseFactory
@@ -40,6 +39,7 @@ import org.wordpress.android.ui.stats.refresh.utils.StatsSiteProvider
4039
import org.wordpress.android.ui.stats.refresh.utils.StatsUtils
4140
import org.wordpress.android.ui.stats.refresh.utils.getBarWidth
4241
import org.wordpress.android.ui.stats.refresh.utils.trackGranular
42+
import org.wordpress.android.ui.utils.ListItemInteraction.Companion.create
4343
import org.wordpress.android.util.analytics.AnalyticsTrackerWrapper
4444
import java.util.Date
4545
import javax.inject.Inject
@@ -109,7 +109,7 @@ constructor(
109109
} else {
110110
val header = Header(R.string.stats_author_label, R.string.stats_author_views_label)
111111
items.add(header)
112-
val maxViews = domainModel.authors.maxBy { it.views }?.views ?: 0
112+
val maxViews = domainModel.authors.maxByOrNull { it.views }?.views ?: 0
113113
domainModel.authors.forEachIndexed { index, author ->
114114
val headerItem = ListItemWithIcon(
115115
iconUrl = author.avatarUrl,

‎WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/granular/usecases/PostsAndPagesUseCase.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import org.wordpress.android.analytics.AnalyticsTracker
66
import org.wordpress.android.fluxc.model.SiteModel
77
import org.wordpress.android.fluxc.model.stats.LimitMode
88
import org.wordpress.android.fluxc.model.stats.time.PostAndPageViewsModel
9-
import org.wordpress.android.fluxc.model.stats.time.PostAndPageViewsModel.ViewsType.HOMEPAGE
109
import org.wordpress.android.fluxc.model.stats.time.PostAndPageViewsModel.ViewsType.ATTACHMENT
10+
import org.wordpress.android.fluxc.model.stats.time.PostAndPageViewsModel.ViewsType.HOMEPAGE
1111
import org.wordpress.android.fluxc.model.stats.time.PostAndPageViewsModel.ViewsType.OTHER
1212
import org.wordpress.android.fluxc.model.stats.time.PostAndPageViewsModel.ViewsType.PAGE
1313
import org.wordpress.android.fluxc.model.stats.time.PostAndPageViewsModel.ViewsType.POST
@@ -16,8 +16,8 @@ import org.wordpress.android.fluxc.store.StatsStore.TimeStatsType.POSTS_AND_PAGE
1616
import org.wordpress.android.fluxc.store.stats.time.PostAndPageViewsStore
1717
import org.wordpress.android.modules.BG_THREAD
1818
import org.wordpress.android.modules.UI_THREAD
19-
import org.wordpress.android.ui.stats.StatsConstants.ITEM_TYPE_HOME_PAGE
2019
import org.wordpress.android.ui.stats.StatsConstants.ITEM_TYPE_ATTACHMENT
20+
import org.wordpress.android.ui.stats.StatsConstants.ITEM_TYPE_HOME_PAGE
2121
import org.wordpress.android.ui.stats.StatsConstants.ITEM_TYPE_POST
2222
import org.wordpress.android.ui.stats.refresh.NavigationTarget.ViewPostDetailStats
2323
import org.wordpress.android.ui.stats.refresh.NavigationTarget.ViewPostsAndPages
@@ -30,7 +30,6 @@ import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.Empty
3030
import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.Header
3131
import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.Link
3232
import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.ListItemWithIcon
33-
import org.wordpress.android.ui.utils.ListItemInteraction.Companion.create
3433
import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.Title
3534
import org.wordpress.android.ui.stats.refresh.lists.sections.granular.GranularStatelessUseCase
3635
import org.wordpress.android.ui.stats.refresh.lists.sections.granular.GranularUseCaseFactory
@@ -40,6 +39,7 @@ import org.wordpress.android.ui.stats.refresh.utils.StatsSiteProvider
4039
import org.wordpress.android.ui.stats.refresh.utils.StatsUtils
4140
import org.wordpress.android.ui.stats.refresh.utils.getBarWidth
4241
import org.wordpress.android.ui.stats.refresh.utils.trackGranular
42+
import org.wordpress.android.ui.utils.ListItemInteraction.Companion.create
4343
import org.wordpress.android.util.analytics.AnalyticsTrackerWrapper
4444
import java.util.Date
4545
import javax.inject.Inject
@@ -112,7 +112,7 @@ constructor(
112112
} else {
113113
val header = Header(R.string.stats_posts_and_pages_title_label, R.string.stats_posts_and_pages_views_label)
114114
items.add(header)
115-
val maxViews = domainModel.views.maxBy { it.views }?.views ?: 0
115+
val maxViews = domainModel.views.maxByOrNull { it.views }?.views ?: 0
116116
items.addAll(domainModel.views.mapIndexed { index, viewsModel ->
117117
val icon = when (viewsModel.type) {
118118
POST -> R.drawable.ic_posts_white_24dp

‎WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/insights/usecases/TagsAndCategoriesUseCase.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.Heade
2626
import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.Link
2727
import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.ListItemWithIcon
2828
import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.ListItemWithIcon.TextStyle.LIGHT
29-
import org.wordpress.android.ui.utils.ListItemInteraction
3029
import org.wordpress.android.ui.stats.refresh.lists.sections.BlockListItem.Title
3130
import org.wordpress.android.ui.stats.refresh.lists.sections.insights.InsightUseCaseFactory
3231
import org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.TagsAndCategoriesUseCase.TagsAndCategoriesUiState
@@ -35,6 +34,7 @@ import org.wordpress.android.ui.stats.refresh.utils.ItemPopupMenuHandler
3534
import org.wordpress.android.ui.stats.refresh.utils.StatsSiteProvider
3635
import org.wordpress.android.ui.stats.refresh.utils.StatsUtils
3736
import org.wordpress.android.ui.stats.refresh.utils.getBarWidth
37+
import org.wordpress.android.ui.utils.ListItemInteraction
3838
import org.wordpress.android.util.analytics.AnalyticsTrackerWrapper
3939
import org.wordpress.android.viewmodel.ResourceProvider
4040
import javax.inject.Inject
@@ -100,7 +100,7 @@ class TagsAndCategoriesUseCase
100100
header
101101
)
102102
val tagsList = mutableListOf<BlockListItem>()
103-
val maxViews = domainModel.tags.maxBy { it.views }?.views ?: 0
103+
val maxViews = domainModel.tags.maxByOrNull { it.views }?.views ?: 0
104104
domainModel.tags.forEachIndexed { index, tag ->
105105
when {
106106
tag.items.size == 1 -> {

‎WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/viewholders/BarChartViewHolder.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class BarChartViewHolder(parent: ViewGroup) : BlockListItemViewHolder(
8383
val count = if (columnNumber > MIN_COLUMN_COUNT) columnNumber else MIN_COLUMN_COUNT
8484
val cutEntries = takeEntriesWithinGraphWidth(count, item.entries)
8585
val mappedEntries = cutEntries.mapIndexed { index, pair -> toBarEntry(pair, index) }
86-
val maxYValue = cutEntries.maxBy { it.value }!!.value
86+
val maxYValue = cutEntries.maxByOrNull { it.value }!!.value
8787
val hasData = item.entries.isNotEmpty() && item.entries.any { it.value > 0 }
8888
val dataSet = if (hasData) {
8989
buildDataSet(context, mappedEntries)
@@ -272,7 +272,7 @@ class BarChartViewHolder(parent: ViewGroup) : BlockListItemViewHolder(
272272
}
273273

274274
private fun getHighlightDataSet(context: Context, cut: List<BarEntry>): BarDataSet? {
275-
val maxEntry = cut.maxBy { it.y } ?: return null
275+
val maxEntry = cut.maxByOrNull { it.y } ?: return null
276276
val highlightedDataSet = cut.map {
277277
BarEntry(it.x, maxEntry.y, it.data)
278278
}

‎WordPress/src/main/res/values/strings.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3402,6 +3402,8 @@
34023402
<string name="gutenberg_native_copied_block" tools:ignore="UnusedResources">Copied block</string>
34033403
<string name="gutenberg_native_copy_block" tools:ignore="UnusedResources">Copy block</string>
34043404
<string name="gutenberg_native_copy_file_url" tools:ignore="UnusedResources">Copy file URL</string>
3405+
<!-- translators: Copy URL from the clipboard, https://sample.url -->
3406+
<string name="gutenberg_native_copy_url_from_the_clipboard_s" tools:ignore="UnusedResources">Copy URL from the clipboard, %s</string>
34053407
<string name="gutenberg_native_create_embed" tools:ignore="UnusedResources">Create embed</string>
34063408
<string name="gutenberg_native_create_link" tools:ignore="UnusedResources">Create link</string>
34073409
<string name="gutenberg_native_crosspost" tools:ignore="UnusedResources">Crosspost</string>
@@ -3482,8 +3484,10 @@
34823484
<string name="gutenberg_native_failed_to_save_files_please_tap_for_options" tools:ignore="UnusedResources">Failed to save files.\nPlease tap for options.</string>
34833485
<string name="gutenberg_native_failed_to_upload_files_please_tap_for_options" tools:ignore="UnusedResources">Failed to upload files.\nPlease tap for options.</string>
34843486
<string name="gutenberg_native_featured" tools:ignore="UnusedResources">Featured</string>
3487+
<string name="gutenberg_native_featured_image" tools:ignore="UnusedResources">Featured Image</string>
34853488
<string name="gutenberg_native_file_block_settings" tools:ignore="UnusedResources">File block settings</string>
34863489
<string name="gutenberg_native_file_name" tools:ignore="UnusedResources">File name</string>
3490+
<string name="gutenberg_native_from_clipboard" tools:ignore="UnusedResources">From clipboard</string>
34873491
<!-- translators: accessibility text. %s: gallery caption. -->
34883492
<string name="gutenberg_native_gallery_caption_s" tools:ignore="UnusedResources">Gallery caption. %s</string>
34893493
<string name="gutenberg_native_give_it_a_try_by_adding_a_few_blocks_to_your_post_or_page" tools:ignore="UnusedResources">Give it a try by adding a few blocks to your post or page!</string>

‎build.gradle

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
buildscript {
2-
ext.kotlinVersion = '1.4.20'
3-
ext.serializationVersion = '1.0-M1-1.4.0-rc'
2+
ext.kotlinVersion = '1.5.32'
3+
ext.coroutinesVersion = '1.5.2'
44
ext.navComponentVersion = '2.3.5'
5-
ext.kotlin_coroutines_version = '1.3.9'
6-
ext.coroutinesVersion = '1.3.9'
7-
ext.kotlin_ktx_version = '1.2.0'
85
ext.wordPressUtilsVersion = '2.2.0'
96
ext.wordPressLoginVersion = '0.0.8'
107
ext.detektVersion = '1.15.0'
@@ -133,7 +130,7 @@ ext {
133130
androidxWorkVersion = "2.4.0"
134131

135132
daggerVersion = '2.29.1'
136-
fluxCVersion = '1.30.0'
133+
fluxCVersion = '1.31.0'
137134

138135
appCompatVersion = '1.0.2'
139136
coreVersion = '1.3.2'

0 commit comments

Comments
 (0)