Skip to content

Commit 93e4b7e

Browse files
authored
Merge pull request #19745 from wordpress-mobile/issue/19743-add-is-free-property-to-the-domain-selected-event
Add `is_free` property to the `jpandroid_enhanced_site_creation_domains_selected` event
2 parents 12baac7 + fcfbb9b commit 93e4b7e

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

WordPress/src/main/java/org/wordpress/android/ui/sitecreation/domains/SiteCreationDomainsViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ class SiteCreationDomainsViewModel @Inject constructor(
133133
val domain = requireNotNull(selectedDomain) {
134134
"Create site button should not be visible if a domain is not selected"
135135
}
136-
tracker.trackDomainSelected(domain.domainName, currentQuery?.value.orEmpty(), domain.cost)
136+
tracker.trackDomainSelected(domain.domainName, currentQuery?.value.orEmpty(), domain.cost, domain.isFree)
137137
_createSiteBtnClicked.value = domain
138138
}
139139

WordPress/src/main/java/org/wordpress/android/ui/sitecreation/misc/SiteCreationTracker.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ class SiteCreationTracker @Inject constructor(
4747
SITE_NAME("site_name"),
4848
RECOMMENDED("recommended"),
4949
DOMAIN_COST("domain_cost"),
50+
IS_FREE("is_free"),
5051
}
5152

5253
private var designSelectionSkipped: Boolean = false
@@ -62,14 +63,15 @@ class SiteCreationTracker @Inject constructor(
6263
tracker.track(AnalyticsTracker.Stat.ENHANCED_SITE_CREATION_DOMAINS_ACCESSED)
6364
}
6465

65-
fun trackDomainSelected(chosenDomain: String, searchTerm: String, domainCost: String = "free") {
66+
fun trackDomainSelected(chosenDomain: String, searchTerm: String, domainCost: String = "free", isFree: Boolean) {
6667
if(plansInSiteCreationFeatureConfig.isEnabled()) {
6768
tracker.track(
6869
AnalyticsTracker.Stat.ENHANCED_SITE_CREATION_DOMAINS_SELECTED,
6970
mapOf(
7071
CHOSEN_DOMAIN.key to chosenDomain,
7172
SEARCH_TERM.key to searchTerm,
7273
PROPERTY.DOMAIN_COST.key to domainCost.lowercase(), // Homogenize data (e.g. "Free" becomes "free")
74+
PROPERTY.IS_FREE.key to isFree,
7375
)
7476
)
7577
} else {

WordPress/src/test/java/org/wordpress/android/ui/sitecreation/domains/SiteCreationDomainsViewModelTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ class SiteCreationDomainsViewModelTest : BaseUnitTest() {
312312

313313
viewModel.onCreateSiteBtnClicked()
314314

315-
verify(tracker).trackDomainSelected(selectedDomain.domainName, "", expectedCost)
315+
verify(tracker).trackDomainSelected(selectedDomain.domainName, "", expectedCost, true)
316316
}
317317

318318
@Test
@@ -324,7 +324,7 @@ class SiteCreationDomainsViewModelTest : BaseUnitTest() {
324324

325325
viewModel.onCreateSiteBtnClicked()
326326

327-
verify(tracker).trackDomainSelected(selectedDomain.domainName, "", expectedCost)
327+
verify(tracker).trackDomainSelected(selectedDomain.domainName, "", expectedCost, false)
328328
}
329329

330330
@Test

0 commit comments

Comments
 (0)