Merge pull request #19761 from wordpress-mobile/fix/19157-TransactionTooLargeException2

Follow up: Replaces bundle usage in the editor with a local database

Author: antonis

WordPress/src/main/java/org/wordpress/android/ui/history/HistoryDetailFragment.kt

@@ -19,9 +19,9 @@ class HistoryDetailFragment : Fragment() {
         super.onCreate(savedInstanceState)
 
         mRevision = if (getDatabase(WordPress.getContext())?.hasParcel(KEY_REVISION) == true) {
-            getDatabase(WordPress.getContext())?.getParcel(KEY_REVISION, parcelableCreator<Revision>())
+            getDatabase(WordPress.getContext())?.getParcel(KEY_REVISION, parcelableCreator())
         } else {
-            getDatabase(WordPress.getContext())?.getParcel(EXTRA_REVISION, parcelableCreator<Revision>())
+            getDatabase(WordPress.getContext())?.getParcel(EXTRA_REVISION, parcelableCreator())
         }
     }
 

libs/editor/src/main/java/org/wordpress/android/editor/savedinstance/SavedInstanceDatabase.kt

@@ -64,21 +64,21 @@ class SavedInstanceDatabase(context: Context?) : SQLiteOpenHelper(context, DB_NA
         private const val DB_NAME = "wpsavedinstance.db"
         private const val DB_VERSION = 1
 
-        private var mSavedInstanceDb: SavedInstanceDatabase? = null
+        private var savedInstanceDb: SavedInstanceDatabase? = null
         private val DB_LOCK = Any()
 
         fun getDatabase(context: Context): SavedInstanceDatabase? {
-            if (mSavedInstanceDb == null) {
+            if (savedInstanceDb == null) {
                 synchronized(DB_LOCK) {
-                    if (mSavedInstanceDb == null) {
-                        mSavedInstanceDb = SavedInstanceDatabase(context.applicationContext)
+                    if (savedInstanceDb == null) {
+                        savedInstanceDb = SavedInstanceDatabase(context.applicationContext)
                         // this ensures that onOpen() is called with a writable database
                         // (open will fail if app calls getReadableDb() first)
-                        mSavedInstanceDb?.writableDatabase
+                        savedInstanceDb?.writableDatabase
                     }
                 }
             }
-            return mSavedInstanceDb
+            return savedInstanceDb
         }
     }
 }