Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the inlineEdit component to scale width with the column width of table #1751

Open
wouter1975 opened this issue Feb 19, 2025 · 0 comments

Comments

@wouter1975
Copy link
Collaborator

wouter1975 commented Feb 19, 2025

This component seems to have a fixed width, which in two situations leads to undesired heavior:

  • When the column width is smaller than the text of the cell, the edit function is not (fully) visible when hoovering over the cell or when the component is in edit mode
Image Image
  • If the text of the table cell longer than visually supported by the component, it will cut off the text, even though the column is much wider.
Image

Proposed solution:

  • Scale the component width with the table column width

When hoovering above the cell

  • Always show the pencil, if needed change the text to text-overflow to create space for the pencil icon

When clicked on cell text, component is in edit mode

  • Always show the cancel/ok buttons, if needed change the text to text-overflow to create space for the buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant