Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.19 - Preload Fonts - Beacon processing part - 2 #7270

Open
jeawhanlee opened this issue Jan 31, 2025 · 2 comments · Fixed by wp-media/rocket-scripts#42
Open

3.19 - Preload Fonts - Beacon processing part - 2 #7270

jeawhanlee opened this issue Jan 31, 2025 · 2 comments · Fixed by wp-media/rocket-scripts#42
Labels
effort: [XS] < 1 day of estimated development time
Milestone

Comments

@jeawhanlee
Copy link
Contributor

User Story

As a user after visiting an uncached page, preload fonts beacon process must not run again.
This is a follow up of this issue where we handle only collation of data.

Acceptance Criteria

  • Preload fonts beacon process should only run once on uncached page.
@jeawhanlee
Copy link
Contributor Author

jeawhanlee commented Jan 31, 2025

This should be done after this & this

Scope a solution ✅

On Beacon:

  • Add a check in the BeaconManager class after this
  • Perform the same check as we do for ATF & LRC
  • Update this conditional here to cater for the preload fonts beacon as well.

Estimate the effort ✅

[XS]

@wordpressfan
Copy link
Contributor

I was thinking of having this in the part 1 of the issue but that's OK to have a dedicated issue for it.

@piotrbak piotrbak added this to the 3.19-prealpha milestone Feb 6, 2025
@piotrbak piotrbak added the effort: [XS] < 1 day of estimated development time label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [XS] < 1 day of estimated development time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants