Merge pull request #1215 from wright-group/create_constant

create_constant kwargs

Author: rpm4

CHANGELOG.md

@@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/).
 
 ## Changed
 - local version identifier uses only ASCII letters/numbers and periods (PEP 440)
+- `Data.create_constant`: allow kwargs to be passed to the constant creation
 
 ## [3.6.0]
 

WrightTools/data/_data.py

@@ -2263,7 +2263,7 @@ def set_constants(self, *constants, verbose=True):
         self.flush()
         self._on_constants_updated()
 
-    def create_constant(self, expression, *, verbose=True):
+    def create_constant(self, expression, verbose=True, **kwargs):
         """Append a constant to the stored list.
 
         Parameters
@@ -2272,6 +2272,8 @@ def create_constant(self, expression, *, verbose=True):
             Expression for the new constant.
         verbose : boolean (optional)
             Toggle talkback. Default is True
+        **kwargs
+            extra kwargs are passed to `Constant.__init__`
 
         See Also
         --------
@@ -2283,7 +2285,7 @@ def create_constant(self, expression, *, verbose=True):
         if expression in self.constant_expressions:
             wt_exceptions.ObjectExistsWarning.warn(expression)
             return self.constants[self.constant_expressions.index(expression)]
-        constant = Constant(self, expression)
+        constant = Constant(self, expression, **kwargs)
         if constant.units is None:
             constant.convert(constant.variables[0].units)
         self._constants.append(constant)

tests/data/constants.py

@@ -18,6 +18,13 @@ def test_set_remove():
     assert data.constant_names == ()
 
 
+def test_units():
+    """smokescreen to make sure units can be specified for constant creation"""
+    data = wt.Data()
+    data.create_variable("y", np.ones((3,)), units="ps")
+    data.create_constant("y", units="wn")
+
+
 def test_label():
     data = wt.Data()
     data.create_variable("x", np.linspace(0, 10))