Skip to content

Commit 1237512

Browse files
Fix
1 parent 915de08 commit 1237512

File tree

2 files changed

+44
-52
lines changed

2 files changed

+44
-52
lines changed

ui.frontend/src/components/ExecutionAbortButton.tsx

Lines changed: 20 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -63,36 +63,32 @@ const ExecutionAbortButton: React.FC<ExecutionAbortButtonProps> = ({ execution,
6363
}
6464
};
6565

66-
const renderAbortDialog = useCallback(() => (
67-
<>
68-
<Heading>
69-
<Text>Confirmation</Text>
70-
</Heading>
71-
<Divider />
72-
<Content>
73-
<p>This action will abort current code execution.</p>
74-
<p>Be aware that aborting execution may leave data in an inconsistent state.</p>
75-
</Content>
76-
<ButtonGroup>
77-
<Button variant="secondary" onPress={() => setShowDialog(false)} isDisabled={isAborting}>
78-
<Cancel />
79-
<Text>Cancel</Text>
80-
</Button>
81-
<Button variant="negative" style="fill" onPress={onAbort} isPending={isAborting}>
82-
<StopCircle />
83-
<Text>Abort</Text>
84-
</Button>
85-
</ButtonGroup>
86-
</>
87-
);
88-
8966
return (
9067
<DialogTrigger isOpen={showDialog} onOpenChange={setShowDialog}>
9168
<Button variant="negative" isDisabled={!execution || !isExecutionPending(execution.status) || isAborting} onPress={() => setShowDialog(true)}>
9269
<StopCircle />
9370
<Text>Abort</Text>
9471
</Button>
95-
<Dialog>{renderAbortDialog()}</Dialog>
72+
<Dialog>
73+
<Heading>
74+
<Text>Confirmation</Text>
75+
</Heading>
76+
<Divider />
77+
<Content>
78+
<p>This action will abort current code execution.</p>
79+
<p>Be aware that aborting execution may leave data in an inconsistent state.</p>
80+
</Content>
81+
<ButtonGroup>
82+
<Button variant="secondary" onPress={() => setShowDialog(false)} isDisabled={isAborting}>
83+
<Cancel />
84+
<Text>Cancel</Text>
85+
</Button>
86+
<Button variant="negative" style="fill" onPress={onAbort} isPending={isAborting}>
87+
<StopCircle />
88+
<Text>Abort</Text>
89+
</Button>
90+
</ButtonGroup>
91+
</Dialog>
9692
</DialogTrigger>
9793
);
9894
};

ui.frontend/src/components/ScriptSynchronizeButton.tsx

Lines changed: 24 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -31,40 +31,36 @@ const ScriptSynchronizeButton: React.FC<ScriptSynchronizeButtonProps> = ({ selec
3131
}
3232
};
3333

34-
const renderSyncDialog = () => (
35-
<>
36-
<Heading>
37-
<Text>Confirmation</Text>
38-
</Heading>
39-
<Divider />
40-
<Content>
41-
<p>
42-
This action will synchronize <strong>all scripts</strong> between the author and publish instances. This ensures consistency across the whole environment.
43-
</p>
44-
<p>
45-
Notice that <strong>both enabled and disabled</strong> scripts will be synchronized.
46-
</p>
47-
</Content>
48-
<ButtonGroup>
49-
<Button variant="secondary" onPress={() => setSyncDialogOpen(false)} isDisabled={isLoading}>
50-
<Cancel />
51-
<Text>Cancel</Text>
52-
</Button>
53-
<Button variant="negative" style="fill" onPress={handleSyncConfirm} isPending={isLoading}>
54-
<Checkmark />
55-
<Text>Confirm</Text>
56-
</Button>
57-
</ButtonGroup>
58-
</>
59-
);
60-
6134
return (
6235
<DialogTrigger isOpen={syncDialogOpen} onOpenChange={setSyncDialogOpen}>
6336
<Button variant="primary" onPress={() => setSyncDialogOpen(true)} isDisabled={selectedKeys.length > 0}>
6437
<UploadToCloud />
6538
<Text>Synchronize</Text>
6639
</Button>
67-
<Dialog>{renderSyncDialog()}</Dialog>
40+
<Dialog>
41+
<Heading>
42+
<Text>Confirmation</Text>
43+
</Heading>
44+
<Divider />
45+
<Content>
46+
<p>
47+
This action will synchronize <strong>all scripts</strong> between the author and publish instances. This ensures consistency across the whole environment.
48+
</p>
49+
<p>
50+
Notice that <strong>both enabled and disabled</strong> scripts will be synchronized.
51+
</p>
52+
</Content>
53+
<ButtonGroup>
54+
<Button variant="secondary" onPress={() => setSyncDialogOpen(false)} isDisabled={isLoading}>
55+
<Cancel />
56+
<Text>Cancel</Text>
57+
</Button>
58+
<Button variant="negative" style="fill" onPress={handleSyncConfirm} isPending={isLoading}>
59+
<Checkmark />
60+
<Text>Confirm</Text>
61+
</Button>
62+
</ButtonGroup>
63+
</Dialog>
6864
</DialogTrigger>
6965
);
7066
};

0 commit comments

Comments
 (0)