Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should use a checksum to protct the incomplete byte code. #51

Open
wycc opened this issue Dec 2, 2012 · 2 comments
Open

We should use a checksum to protct the incomplete byte code. #51

wycc opened this issue Dec 2, 2012 · 2 comments
Labels

Comments

@wycc
Copy link
Collaborator

wycc commented Dec 2, 2012

If the byte code is not downloaded completely, we should drop it.

@ghost ghost assigned nielsreijers Dec 2, 2012
@wycc
Copy link
Collaborator Author

wycc commented Dec 14, 2012

If we fail to update the complete byte code, the VM should not execute the byte code at all so that it won't create wired situation.

@nielsreijers
Copy link
Collaborator

The upload process already checks for missing packets and will let the master know if any gaps are detected. Zwave already includes a checksum to verify the contents of the packet.
If an incorrect bytecode is uploaded, for instance by turning off the node in the middle of the reprogramming procedure, it will start to run the corrupted bytecode, but will most likely just crash immediately. Either way, the node will still listen to the radio so it can be reprogrammed again.

This checksum would still be good to have as an extra precaution, so I won't close the issue yet, but it does seem to be a nice-to-have at this point, so I'll put it in "won't fix" instead for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants