Fix compatibility issues and update documentation for next hotfix release

Author: romanstrobl

docs/PowerAuth-Server-0.22.0.md

@@ -313,3 +313,7 @@ The [VerifyOfflineSignature](./SOAP-Service-Methods.md#method-verifyofflinesigna
 ### External User Identifier
 
 The [CommitActivation](./SOAP-Service-Methods.md#method-commitactivation), [RemoveActivation](./SOAP-Service-Methods.md#method-removeactivation), [BlockActivation](./SOAP-Service-Methods.md#method-blockactivation) and [UnblockActivation](./SOAP-Service-Methods.md#method-unblockactivation) methods have been updated to allow specification of external user identifier. The related PowerAuth client methods have been updated to reflect the change of parameters. If you use any of these methods, please update the SOAP method call.
+
+### Revoking Recovery Codes on Activation Removal
+
+We added an optional `revokeRecoveryCodes` attribute to [activation removal service call](./SOAP-Service-Methods.md#method-removeactivation). This flag indicates if recovery codes that are associated with removed activation should be also revoked. By default, the value of the flag is `false`, hence omitting the flag results in the same behavior as before this change. 

docs/SOAP-Service-Methods.md

@@ -486,6 +486,7 @@ Remove activation with given ID. This operation is irreversible. Activations can
 |------|------|-------------|
 | `String` | `activationId` | An identifier of an activation |
 | `String` | `externalUserId` | User ID of user who removed the activation. Use null value if activation owner caused the change. |
+| `Boolean` | `revokeRecoveryCodes` | An optional flag that indicates if recovery codes, that were created in the scope of the removed activation, should be also revoked. |
 
 #### Response
 

powerauth-java-client-axis/src/main/java/io/getlime/security/powerauth/soap/axis/client/PowerAuthServiceClient.java

@@ -398,7 +398,7 @@ public PowerAuthPortV3ServiceStub.RemoveActivationResponse removeActivation(Stri
      * @return {@link io.getlime.powerauth.soap.v3.PowerAuthPortV3ServiceStub.RemoveActivationResponse}
      * @throws RemoteException In case of a business logic error.
      */
-    public PowerAuthPortV3ServiceStub.RemoveActivationResponse removeActivation(String activationId, String externalUserId, boolean revokeRecoveryCodes) throws RemoteException {
+    public PowerAuthPortV3ServiceStub.RemoveActivationResponse removeActivation(String activationId, String externalUserId, Boolean revokeRecoveryCodes) throws RemoteException {
         PowerAuthPortV3ServiceStub.RemoveActivationRequest request = new PowerAuthPortV3ServiceStub.RemoveActivationRequest();
         request.setActivationId(activationId);
         request.setExternalUserId(externalUserId);

powerauth-java-client-spring/src/main/java/io/getlime/security/powerauth/soap/spring/client/PowerAuthServiceClient.java

@@ -268,7 +268,7 @@ public RemoveActivationResponse removeActivation(String activationId, String ext
      * @param revokeRecoveryCodes Indicates if the recovery codes associated with this activation should be also revoked.
      * @return {@link RemoveActivationResponse}
      */
-    public RemoveActivationResponse removeActivation(String activationId, String externalUserId, boolean revokeRecoveryCodes) {
+    public RemoveActivationResponse removeActivation(String activationId, String externalUserId, Boolean revokeRecoveryCodes) {
         RemoveActivationRequest request = new RemoveActivationRequest();
         request.setActivationId(activationId);
         request.setExternalUserId(externalUserId);

powerauth-java-server/src/main/java/io/getlime/security/powerauth/app/server/service/v3/PowerAuthServiceImpl.java

@@ -404,7 +404,11 @@ public RemoveActivationResponse removeActivation(RemoveActivationRequest request
         try {
             String activationId = request.getActivationId();
             String externalUserId = request.getExternalUserId();
-            boolean revokeRecoveryCodes = request.isRevokeRecoveryCodes();
+            Boolean revokeRecoveryCodes = request.isRevokeRecoveryCodes();
+            if (revokeRecoveryCodes == null) {
+                // The default value is false for revokeRecoveryCodes
+                revokeRecoveryCodes = false;
+            }
             logger.info("RemoveActivationRequest received, activation ID: {}, revoke recovery codes: {}", activationId, revokeRecoveryCodes);
             RemoveActivationResponse response = behavior.getActivationServiceBehavior().removeActivation(activationId, externalUserId, revokeRecoveryCodes);
             logger.info("RemoveActivationRequest succeeded");