Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please add externally_connectable property definition #956

Closed
honwhy opened this issue Sep 1, 2024 · 5 comments · Fixed by #969
Closed

please add externally_connectable property definition #956

honwhy opened this issue Sep 1, 2024 · 5 comments · Fixed by #969
Labels
duplicate This issue or pull request already exists feature

Comments

@honwhy
Copy link

honwhy commented Sep 1, 2024

add externally_connectable property to manifest definition

interface WebExtensionManifest lack of externally_connectable property

externally_connectable explains here, https://developer.chrome.com/docs/extensions/reference/manifest/externally-connectable
@honwhy honwhy added the feature label Sep 1, 2024
@aklinker1 aklinker1 linked a pull request Sep 3, 2024 that will close this issue
feat: Use @types/chrome for config manifest type #969
Merged
@aklinker1 aklinker1 added the duplicate This issue or pull request already exists label Sep 3, 2024
@aklinker1
Copy link
Collaborator

Duplicate of #521

@aklinker1 aklinker1 marked this as a duplicate of #521 Sep 3, 2024
@aklinker1 aklinker1 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
@aklinker1
Copy link
Collaborator

Released in v0.19.9

@aleclarson
Copy link
Contributor

Hi @aklinker1! 👋

I think you closed this prematurely. There is still no externally_connectable property in WXT's UserManifest type. Proof here: https://github.com/search?q=repo%3Awxt-dev%2Fwxt%20externally_connectable&type=code

@aklinker1
Copy link
Collaborator

@aleclarson Seems to work just fine? What version of WXT are you on?

Image

@aklinker1
Copy link
Collaborator

aklinker1 commented Feb 12, 2025 •
edited
Loading

@aleclarson Maybe you're experiencing #1116?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Use @types/chrome for config manifest type wxt-dev/wxt
3 participants
@aleclarson @honwhy @aklinker1