Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample rate error #20

Open
njoyard opened this issue Sep 16, 2014 · 1 comment
Open

Sample rate error #20

njoyard opened this issue Sep 16, 2014 · 1 comment
Assignees
Labels

Comments

@njoyard
Copy link

njoyard commented Sep 16, 2014

I'm getting a crash when trying to load a 176.4kHz sound (from freedoom WAD). Works find from wadexplorer, though.

Fixed with

AudioBuffer audioBuffer = audioContext.createBuffer(1,  sample.sampleCount*4, sample.rate*2);

But I'm not sure of the impacts of that change (not sure why you put *4 in the first place, either).

@xNotch
Copy link
Owner

xNotch commented Sep 17, 2014

The *4 was to fakely upsample from 11khz to 44khz, as some webaudio implementations seemed to not enjoy 11khz samples. But, yeah, I happily ignore the sample rate in the wad file and just ASSUME 11khz, which probably isn't very sane.

@xNotch xNotch self-assigned this Sep 17, 2014
@xNotch xNotch added the bug label Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants