CA-408048 remove SM plugins from DB if unavailable

An SM plugin might become unavailable; we have to remove its record on
xapi startup. The canonical case is an upgrade from XS8 to XS9.

Signed-off-by: Christian Lindig <[email protected]>

Author: Christian Lindig

ocaml/xapi/storage_access.ml

@@ -109,10 +109,16 @@ exception Message_switch_failure
 (** Synchronise the SM table with the SMAPIv1 plugins on the disk and the SMAPIv2
     plugins mentioned in the configuration file whitelist. *)
 let on_xapi_start ~__context =
+  (* An SM is either implemented as a plugin - for which we check its
+      presence, or via an API *)
+  let is_available (_rf, rc) =
+    Sys.file_exists rc.API.sM_driver_filename
+    || Version.String.ge rc.sM_required_api_version "5.0"
+  in
   let existing =
-    List.map
-      (fun (rf, rc) -> (rc.API.sM_type, (rf, rc)))
-      (Db.SM.get_all_records ~__context)
+    Db.SM.get_all_records ~__context
+    |> List.filter is_available
+    |> List.map (fun (rf, rc) -> (rc.API.sM_type, (rf, rc)))
   in
   let explicitly_configured_drivers =
     List.filter_map