fix await-thenable lint

Author: dynst

.eslintrc

@@ -20,6 +20,7 @@
     },
   },
   "rules": {
+    "@typescript-eslint/await-thenable": "error",
     "@typescript-eslint/explicit-module-boundary-types": "off",
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/no-use-before-define": "warn",

packages/xchain-cardano/__tests__/client.test.ts

@@ -224,13 +224,13 @@ describe('Cardano client', () => {
         // Test valid address
         const validAddress =
           'addr1qy8ac7qqy0vtulyl7wntmsxc6wex80gvcyjy33qffrhm7sh927ysx5sftuw0dlft05dz3c7revpf7jx0xnlcjz3g69mq4afdhv'
-        const validResult = await client.validateAddress(validAddress)
+        const validResult = client.validateAddress(validAddress)
         expect(validResult).toBeTruthy()
 
         // Test invalid address
         const invalidAddress =
           'addr1qy8ac7qqy0vtulyl7wntmsxc6wex80gvcyjy33qffrhm7sh927ysx5sftuw0dlft05dz3c7revpf7jx0xnlcjz3g69mq4afdhf'
-        const invalidResult = await client.validateAddress(invalidAddress)
+        const invalidResult = client.validateAddress(invalidAddress)
         expect(invalidResult).toBeFalsy()
       })
     })

packages/xchain-evm/__tests__/client.test.ts

@@ -165,7 +165,7 @@ describe('EVM client', () => {
   })
 
   it('Should throw error with invalid phrase', async () => {
-    await expect(() => {
+    expect(() => {
       new Client({
         ...avaxParams,
         signer: new KeystoreSigner({
@@ -186,7 +186,7 @@ describe('EVM client', () => {
 
   it('Should not have a phrase after purging', async () => {
     avaxClient.purgeClient()
-    await expect(() => avaxClient.getAddress()).toThrow()
+    expect(() => avaxClient.getAddress()).toThrow()
   })
 
   it('Should set new phrase', () => {
@@ -196,7 +196,7 @@ describe('EVM client', () => {
   })
 
   it('should fail to set new phrase', async () => {
-    await expect(() => avaxClient.setPhrase('bad bad phrase')).toThrow()
+    expect(() => avaxClient.setPhrase('bad bad phrase')).toThrow()
   })
 
   it('Should get network', () => {

packages/xchain-evm/src/signers/ledgerSigner.ts

@@ -62,7 +62,7 @@ export class LedgerSigner extends Signer {
     const unsignedTx = tx.unsignedSerialized.substring(2)
     const resolution = await ledgerService.resolveTransaction(unsignedTx, {}, { externalPlugins: true, erc20: true })
 
-    const ethApp = await this.getApp()
+    const ethApp = this.getApp()
 
     const signatureData = await ethApp.signTransaction(this.getFullDerivationPath(walletIndex), unsignedTx, resolution)
 
@@ -89,7 +89,7 @@ export class LedgerSigner extends Signer {
 
     const resolution = await ledgerService.resolveTransaction(unsignedTx, {}, { externalPlugins: true, erc20: true })
 
-    const ethApp = await this.getApp()
+    const ethApp = this.getApp()
     const signatureData = await ethApp.signTransaction(this.getFullDerivationPath(walletIndex), unsignedTx, resolution)
 
     tx.signature = {

packages/xchain-evm/src/utils.ts

@@ -121,7 +121,7 @@ export const estimateCall = async ({
 }): Promise<BigNumber> => {
   const contract = new Contract(contractAddress, abi, provider)
   const estiamtion = await contract.getFunction(funcName).estimateGas(...funcParams)
-  return await new BigNumber(estiamtion.toString())
+  return new BigNumber(estiamtion.toString())
 }
 /**
  * Calls a contract function.

packages/xchain-kujira/__tests__/kujira-client.test.ts

@@ -34,11 +34,11 @@ describe('Kujira client Integration Tests', () => {
     expect(fees.average).toBe(DEFAULT_FEE)
   })
   it('get explorer address url', async () => {
-    const url = await xchainClient.getExplorerAddressUrl('kujira1k688m5uq5gqwt2sltvvu0679vnh3ehlslvf9e2')
+    const url = xchainClient.getExplorerAddressUrl('kujira1k688m5uq5gqwt2sltvvu0679vnh3ehlslvf9e2')
     expect(url).toBe('https://finder.kujira.network/harpoon-4/address/kujira1k688m5uq5gqwt2sltvvu0679vnh3ehlslvf9e2')
   })
   it('get explorer tx url', async () => {
-    const url = await xchainClient.getExplorerTxUrl('F3131AE603FFDE602217330410DD3ADFB9E21C987DDAA5CCF54F99DB15A6714B')
+    const url = xchainClient.getExplorerTxUrl('F3131AE603FFDE602217330410DD3ADFB9E21C987DDAA5CCF54F99DB15A6714B')
     expect(url).toBe(
       'https://finder.kujira.network/harpoon-4/tx/F3131AE603FFDE602217330410DD3ADFB9E21C987DDAA5CCF54F99DB15A6714B',
     )

packages/xchain-mayachain-query/__tests__/mayachain-query.test.ts

@@ -148,29 +148,29 @@ describe('Mayachain-query tests', () => {
   })
 
   it('Should return the number of decimals of Mayachain assets', async () => {
-    await expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('BTC.BTC') as Asset)).toBe(8)
-    await expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('BTC/BTC') as SynthAsset)).toBe(8)
-    await expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('ETH.ETH') as Asset)).toBe(18)
-    await expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('DASH.DASH') as Asset)).toBe(8)
-    await expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('KUJI.KUJI') as Asset)).toBe(6)
-    await expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('THOR.RUNE') as Asset)).toBe(8)
-    await expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('MAYA.CACAO') as Asset)).toBe(10)
-    await expect(
+    expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('BTC.BTC') as Asset)).toBe(8)
+    expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('BTC/BTC') as SynthAsset)).toBe(8)
+    expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('ETH.ETH') as Asset)).toBe(18)
+    expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('DASH.DASH') as Asset)).toBe(8)
+    expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('KUJI.KUJI') as Asset)).toBe(6)
+    expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('THOR.RUNE') as Asset)).toBe(8)
+    expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('MAYA.CACAO') as Asset)).toBe(10)
+    expect(
       await mayachainQuery.getAssetDecimals(
         assetFromStringEx('ETH.USDT-0xdAC17F958D2ee523a2206206994597C13D831ec7') as TokenAsset,
       ),
     ).toBe(6)
-    await expect(
+    expect(
       await mayachainQuery.getAssetDecimals(
         assetFromStringEx('ETH.USDC-0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48') as TokenAsset,
       ),
     ).toBe(6)
-    await expect(
+    expect(
       await mayachainQuery.getAssetDecimals(
         assetFromStringEx('ETH.WSTETH-0X7F39C581F595B53C5CB19BD0B3F8DA6C935E2CA0') as TokenAsset,
       ),
     ).toBe(18)
-    await expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('KUJI.USK') as TokenAsset)).toBe(6)
+    expect(await mayachainQuery.getAssetDecimals(assetFromStringEx('KUJI.USK') as TokenAsset)).toBe(6)
     await expect(
       mayachainQuery.getAssetDecimals(
         assetFromStringEx('ETH.BNB-0xB8c77482e45F1F44dE1745F52C74426C631bDD52') as TokenAsset,

packages/xchain-radix/__tests__/client.test.ts

@@ -60,7 +60,7 @@ describe('RadixClient Test', () => {
       network: Network.Mainnet,
       phrase: phrase,
     }
-    await expect(() => new Client(params)).toThrow(/Invalid phrase/)
+    expect(() => new Client(params)).toThrow(/Invalid phrase/)
   })
 
   it('client should be able to get address', async () => {
@@ -82,7 +82,7 @@ describe('RadixClient Test', () => {
 
   it('client should throw an Error when using getAddress', async () => {
     const client = createClient()
-    await expect(() => client.getAddress()).toThrow(
+    expect(() => client.getAddress()).toThrow(
       /getAddress is synchronous and cannot retrieve addresses directly. Use getAddressAsync instead./,
     )
   })
@@ -305,7 +305,7 @@ describe('RadixClient Test', () => {
       limit: 200,
       asset: 'resource_rdx1tknxxxxxxxxxradxrdxxxxxxxxx009923554798xxxxxxxxxradxrd',
     }
-    const txs = await (await client.getTransactions(transactionsHistoryParams)).txs
+    const txs = (await client.getTransactions(transactionsHistoryParams)).txs
     txs.forEach((tx) => {
       expect(tx.from).not.toBeUndefined()
       expect(tx.to).not.toBeUndefined()

packages/xchain-ripple/src/clientKeystore.ts

@@ -38,7 +38,7 @@ export class ClientKeystore extends Client {
    * @throws {"Phrase must be provided"} Thrown if the phrase has not been set before.
    */
   public async getAddressAsync(walletIndex = 0): Promise<string> {
-    return await this.getAddress(walletIndex)
+    return this.getAddress(walletIndex)
   }
 
   /**
@@ -48,7 +48,7 @@ export class ClientKeystore extends Client {
    * @returns Transaction signed by phrase
    */
   public async signTransaction(payment: Payment, walletIndex = 0): Promise<SignedTransaction> {
-    const xrplAccount = await this.getXrplWallet(walletIndex)
+    const xrplAccount = this.getXrplWallet(walletIndex)
     return xrplAccount.sign(payment)
   }
 }

packages/xchain-solana/__e2e__/client.e2e.ts

@@ -61,7 +61,7 @@ describe('Solana client', () => {
   })
 
   it('Should validate address', async () => {
-    const res = await client.validateAddress('GHityuQumkHn8JPpHYt9oxR5xi9X8R2kWsprdH9nPvT7')
+    const res = client.validateAddress('GHityuQumkHn8JPpHYt9oxR5xi9X8R2kWsprdH9nPvT7')
     console.log(res)
   })