Skip to content

Commit 506abfb

Browse files
committed
Fix PMD reported problems
1 parent 5ac4e23 commit 506abfb

File tree

2 files changed

+13
-16
lines changed

2 files changed

+13
-16
lines changed

spring-security-advanced-authentication-ui/src/main/java/software/xdev/spring/security/web/authentication/ui/extendable/filters/ExtendableDefaultLoginPageGeneratingFilter.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -352,16 +352,14 @@ protected String renderPasskeyLogin()
352352

353353
protected String renderHeaders(final HttpServletRequest request)
354354
{
355-
final StringBuilder javascriptHeadersEntries = new StringBuilder();
356-
final Map<String, String> headers = this.resolveHeaders.apply(request);
357-
for(final Map.Entry<String, String> header : headers.entrySet())
358-
{
359-
javascriptHeadersEntries.append(HtmlTemplates.fromTemplate(CSRF_HEADERS)
355+
return this.resolveHeaders.apply(request)
356+
.entrySet()
357+
.stream()
358+
.map(header -> HtmlTemplates.fromTemplate(CSRF_HEADERS)
360359
.withValue("headerName", header.getKey())
361360
.withValue("headerValue", header.getValue())
362-
.render());
363-
}
364-
return javascriptHeadersEntries.toString();
361+
.render())
362+
.collect(Collectors.joining());
365363
}
366364

367365
protected String renderFormLogin(

spring-security-advanced-authentication-ui/src/main/java/software/xdev/spring/security/web/authentication/ui/extendable/filters/ExtendableDefaultLogoutPageGeneratingFilter.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import java.util.Map;
2121
import java.util.Set;
2222
import java.util.function.Function;
23+
import java.util.stream.Collectors;
2324

2425
import jakarta.servlet.FilterChain;
2526
import jakarta.servlet.ServletException;
@@ -113,16 +114,14 @@ public void setResolveHiddenInputs(final Function<HttpServletRequest, Map<String
113114
"PMD.InefficientStringBuffering"})
114115
protected String renderHiddenInputs(final HttpServletRequest request)
115116
{
116-
final StringBuilder sb = new StringBuilder();
117-
for(final Map.Entry<String, String> input : this.resolveHiddenInputs.apply(request).entrySet())
118-
{
119-
final String inputElement = HtmlTemplates.fromTemplate(HIDDEN_HTML_INPUT_TEMPLATE)
117+
return this.resolveHiddenInputs.apply(request)
118+
.entrySet()
119+
.stream()
120+
.map(input -> HtmlTemplates.fromTemplate(HIDDEN_HTML_INPUT_TEMPLATE)
120121
.withValue("name", input.getKey())
121122
.withValue("value", input.getValue())
122-
.render();
123-
sb.append(inputElement);
124-
}
125-
return sb.toString();
123+
.render())
124+
.collect(Collectors.joining());
126125
}
127126

128127
// Method is missing on upstream

0 commit comments

Comments
 (0)