Merge pull request #96 from xendit/release/3.10.3

Fix memory leak on WebViewController

Author: ahmadAlfhajri

README.md

@@ -19,7 +19,7 @@ Note that starting version 3.10.0, it requires minimum version of iOS 11. If you
 Add this to your Podfile.
 
 ```ruby
-pod 'Xendit', '~> 3.10.2'
+pod 'Xendit', '~> 3.10.3'
 ```
 
 **Important:** Import SDK in Objective-C project with CocoaPods integration, you can do as following

Sources/Xendit/Info.plist

@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>3.10.2</string>
+	<string>3.10.3</string>
 	<key>CFBundleVersion</key>
 	<string>$(CURRENT_PROJECT_VERSION)</string>
 	<key>NSPrincipalClass</key>

Sources/Xendit/WebViewController/AuthenticationWebviewController.swift

@@ -19,8 +19,8 @@ class AuthenticationProvider: AuthenticationProviderProtocol {
     func authenticate(fromViewController: UIViewController, URL: String, authentication: XenditAuthentication, completion: @escaping (XenditAuthentication?, XenditError?) -> Void) {
         let webViewController = AuthenticationWebViewController(URL: URL)
         webViewController.authentication = authentication
-        webViewController.authenticateCompletion = { updatedAuthentication, error in
-            webViewController.dismiss(animated: true, completion: nil)
+        webViewController.authenticateCompletion = { [weak webViewController] updatedAuthentication, error in
+            webViewController?.dismiss(animated: true, completion: nil)
             completion(updatedAuthentication, error)
         }
         DispatchQueue.main.async {

Sources/Xendit/WebViewController/WebViewController.swift

@@ -20,8 +20,8 @@ class CardAuthenticationProvider: CardAuthenticationProviderProtocol {
         let webViewController = WebViewController(URL: URL)
 
         webViewController.token = authenticatedToken
-        webViewController.authenticateCompletion = { (token, error) -> Void in
-            webViewController.dismiss(animated: true, completion: nil)
+        webViewController.authenticateCompletion = { [weak webViewController] (token, error) -> Void in
+            webViewController?.dismiss(animated: true, completion: nil)
             guard error == nil else {
                 return completion(nil, error)
             }

Sources/Xendit/XDTApiClient.swift

@@ -38,7 +38,7 @@ class XDTApiClient {
     internal static let CLIENT_TYPE = "SDK";
     internal static let CLIENT_API_VERSION = "2.0.0";
     internal static let CLIENT_IDENTIFIER = "Xendit iOS SDK";
-    internal static let CLIENT_SDK_VERSION = "3.10.2";
+    internal static let CLIENT_SDK_VERSION = "3.10.3";
 
     private static let WEBAPI_FLEX_BASE_URL = "https://sandbox.webapi.visa.com"
 

Xendit.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'Xendit'
-  s.version          = '3.10.2'
+  s.version          = '3.10.3'
   s.license          = 'MIT'
   s.homepage         = 'https://www.xendit.co'
   s.author           = { 'Juan Gonzalez’' => '[email protected]' }