Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Model Refinements #1279

Closed
xeolabs opened this issue Dec 2, 2023 · 1 comment
Closed

Split Model Refinements #1279

xeolabs opened this issue Dec 2, 2023 · 1 comment
Milestone

Comments

@xeolabs
Copy link
Member

xeolabs commented Dec 2, 2023

Feature requests for consideration:

Support for File URLs in Split Model Manifest JSON

It would be highly beneficial to enable the inclusion of file URLs as sources in the split model manifest JSON. Ideally, the format would resemble the following:

{ "xktFiles": [ "https://url.to.file.ifc", "https://url.to.second.file" ] }

Currently, the loadXKTs method necessitates a strict directory structure when calling getXKT(${baseDir}${xktFiles[i]}. Allowing file URLs as sources would offer greater flexibility in file sourcing.

Option to Set manifestSrc as a JavaScript Object

An additional improvement would be the ability to set manifestSrc directly as a JavaScript object, rather than solely as a path to a JSON file. This enhancement would provide more versatility in how the manifest data is handled and integrated.

Update to TypeScript Types

I've observed that the manifestSrc property is currently not included in the TypeScript type LoadXKTModel within the file XKTLoaderPlugin.d.ts.

@xeolabs xeolabs added this to the 2.4.2 milestone Dec 2, 2023
xeolabs added a commit that referenced this issue Dec 3, 2023
xeolabs added a commit that referenced this issue Dec 3, 2023
@xeolabs
Copy link
Member Author

xeolabs commented Dec 3, 2023

Fixed by #1283 and #1281

@xeolabs xeolabs closed this as completed Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant