Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSP: xmlns in response causes a failure to parse an ad from the response #347

Closed
dasgarner opened this issue Jan 29, 2025 · 0 comments
Closed

SSP: xmlns in response causes a failure to parse an ad from the response #347

dasgarner opened this issue Jan 29, 2025 · 0 comments
Assignees
@dasgarner
Milestone
4 R405

Comments

@dasgarner
Copy link
Member

XMLNS requires the NS be passed to instances of SelectSingleNode, but we currently assume no namespace is provided (because most SSPs do not provide one).

We should either detect that a namespace is present and use it, or strip it out before parsing.
@dasgarner dasgarner added this to the 4 R405 milestone Jan 29, 2025
@dasgarner dasgarner self-assigned this Jan 29, 2025
dasgarner added a commit to dasgarner/xibo-dotnetclient that referenced this issue Jan 29, 2025
@dasgarner
SSP: strip out namespaces
6c5f5c4 
fixes xibosignage#347
dasgarner added a commit to dasgarner/xibo-dotnetclient that referenced this issue Jan 29, 2025
@dasgarner
Backport fixes from v4
a699926 
xibosignage#346 xibosignage#347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasgarner dasgarner

Labels
None yet
Projects
None yet
Milestone
4 R405
Development

No branches or pull requests
1 participant
@dasgarner