Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching SCW Verifier for server-side use #1126

Closed
neekolas opened this issue Oct 9, 2024 · 0 comments · Fixed by #1625
Closed

Caching SCW Verifier for server-side use #1126

neekolas opened this issue Oct 9, 2024 · 0 comments · Fixed by #1625
Assignees
Labels
smart-contract-wallet Add support for Smart Contract Wallets in libxmtp

Comments

@neekolas
Copy link
Contributor

neekolas commented Oct 9, 2024

Follow up to #1070

One thing that would be really nice for the server is a SmartContractSignatureVerifier that caches the results for a given input in memory.

If you imagine a user getting added to a 200 person group, all 200 members are going to have to go and verify that same signature. Will be both faster and cheaper if we can cache the result.

Since the results are immutable we can theoretically cache forever, but we should give it a bounded size so we can never run out of memory getting spammed. Maybe a LRU cache.

@codabrink codabrink self-assigned this Oct 9, 2024
@fbac fbac assigned fbac and unassigned codabrink Feb 10, 2025
@fbac fbac added the smart-contract-wallet Add support for Smart Contract Wallets in libxmtp label Feb 10, 2025
@fbac fbac moved this to In Progress in Decentralization Feb 12, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Decentralization Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smart-contract-wallet Add support for Smart Contract Wallets in libxmtp
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants