Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin 7.3.0 support #37

Open
peterback opened this issue Apr 29, 2014 · 4 comments
Open

Vaadin 7.3.0 support #37

peterback opened this issue Apr 29, 2014 · 4 comments

Comments

@peterback
Copy link

Hiya,
Thank you for a great add-on! Unfortunately there's been a change in the upcoming Vaadin release (7.3.0) that is incompatible with this add-on as it stands.

This is because there is no longer a VaadinSession.getCurrent().getPreserveOnRefreshUIs() -method present, I was able to make it work for me by just commenting out the whole bit that deals with that in SpringUIProvider.getUIClass() but not at all sure if that's just because this is meant to deal with a scenario which isn't present in my app or if Vaadin just deals with refresh-persistent UI's in a way now that doesn't require you to do this bit.

Thanks,
Peter

@eXsio
Copy link

eXsio commented May 16, 2014

+1, this addon doesn't work with 7.2.0 either...

@dgommeren
Copy link

+1, I need a feature of Vaadin 7.2.0 so really would like an updated version

@dgommeren
Copy link

Don't know where to best place this, but I've made a fork with the offending code removed. The Spring session annotation instead of @PreserveOnRefresh is probably not going to work anymore:
https://github.com/dgommeren/spring-vaadin

@xpoft
Copy link
Owner

xpoft commented Jun 9, 2014

I've updated the add-on. Versions 3.x support Vaadin 7.2.x.
About 7.3.0, I think I'll create a branch for that version, but till it'll be released I don't think the add-on should be published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants