Skip to content

Commit a5fc111

Browse files
authored
Merge pull request #5180 from Tyriar/5179
Forward integration test exit code to running proc
2 parents 9186c72 + 5623ba6 commit a5fc111

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

addons/addon-web-links/test/WebLinksAddon.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,10 @@ test.describe('WebLinksAddon', () => {
3434

3535
test.beforeEach(async () => {
3636
await ctx.page.evaluate(`
37-
window.term.reset()
37+
window.term.reset();
38+
`);
39+
await timeout(50);
40+
await ctx.page.evaluate(`
3841
window._linkaddon?.dispose();
3942
window._linkaddon = new WebLinksAddon();
4043
window.term.loadAddon(window._linkaddon);

bin/test_integration.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ async function run() {
6262
console.error(run.error);
6363
process.exit(run.status ?? -1);
6464
}
65+
66+
process.exit(run.status);
6567
}
6668
}
6769
run();

test/playwright/Terminal.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,7 @@ test.describe('API Integration Tests', () => {
690690
window.term = new Terminal();
691691
window.term.dispose();
692692
`);
693-
strictEqual(await ctx.page.evaluate(`window.term._core._isDisposed`), true);
693+
strictEqual(await ctx.page.evaluate(`window.term._core._store._isDisposed`), true);
694694
});
695695

696696
test('dispose (opened)', async () => {
@@ -702,7 +702,7 @@ test.describe('API Integration Tests', () => {
702702
} catch {}
703703
}
704704
`);
705-
strictEqual(await ctx.page.evaluate(`window.term._core._isDisposed`), true);
705+
strictEqual(await ctx.page.evaluate(`window.term._core._store._isDisposed`), true);
706706
});
707707

708708
test('render when visible after hidden', async () => {

0 commit comments

Comments
 (0)