From 96dbea445b1c855bbf69b0eb73f9fd1639706f89 Mon Sep 17 00:00:00 2001 From: Xudong Zheng <7pkvm5aw@slicealias.com> Date: Sun, 23 Jul 2023 23:51:53 -0400 Subject: [PATCH] refactor(underglow): allow full range for initial brightness The brightness is already scaled within zmk_rgb_underglow_tick(). With the current range condition, setting max brightness to 20% results in starting with 4% (20% of 20%) brightness. --- app/Kconfig | 2 +- app/Kconfig.defaults | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/Kconfig b/app/Kconfig index 5fc03822a02d..509083796977 100644 --- a/app/Kconfig +++ b/app/Kconfig @@ -314,7 +314,7 @@ config ZMK_RGB_UNDERGLOW_SAT_START config ZMK_RGB_UNDERGLOW_BRT_START int "RGB underglow start brightness value in percent" - range ZMK_RGB_UNDERGLOW_BRT_MIN ZMK_RGB_UNDERGLOW_BRT_MAX + range 0 100 config ZMK_RGB_UNDERGLOW_SPD_START int "RGB underglow start animation speed value" diff --git a/app/Kconfig.defaults b/app/Kconfig.defaults index 02d845f1ba4d..109c38bc0d4a 100644 --- a/app/Kconfig.defaults +++ b/app/Kconfig.defaults @@ -44,7 +44,7 @@ config ZMK_RGB_UNDERGLOW_SAT_START default 100 config ZMK_RGB_UNDERGLOW_BRT_START - default ZMK_RGB_UNDERGLOW_BRT_MAX + default 100 config ZMK_RGB_UNDERGLOW_SPD_START default 3 @@ -80,4 +80,4 @@ config ZMK_BATTERY_REPORT_INTERVAL default 60 # Imports -rsource "src/split/Kconfig.defaults" \ No newline at end of file +rsource "src/split/Kconfig.defaults"