Commit 6d578fc
committed
Fail the devcontainer CI job when rake spec fails
The runCmd is a multi-line bash script with no `set -e`, so a non-zero
exit from `bundle exec rake spec` does not propagate. The script keeps
running, executes `bundle exec rubocop`, and the script's exit code
becomes RuboCop's exit code. As long as RuboCop is clean, GitHub
Actions marks the job green even when rspec is red.
Run 26084989755 hit this: 4 ORA-01805 failures in rake spec, but the
job was reported as success because RuboCop passed.
Add `set -e` so the first non-zero exit aborts the script and surfaces
through the action as a job failure.1 parent ac47d27 commit 6d578fc
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
0 commit comments