Skip to content

Commit 6d578fc

Browse files
committed
Fail the devcontainer CI job when rake spec fails
The runCmd is a multi-line bash script with no `set -e`, so a non-zero exit from `bundle exec rake spec` does not propagate. The script keeps running, executes `bundle exec rubocop`, and the script's exit code becomes RuboCop's exit code. As long as RuboCop is clean, GitHub Actions marks the job green even when rspec is red. Run 26084989755 hit this: 4 ORA-01805 failures in rake spec, but the job was reported as success because RuboCop passed. Add `set -e` so the first non-zero exit aborts the script and surfaces through the action as a job failure.
1 parent ac47d27 commit 6d578fc

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

.github/workflows/devcontainer.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ jobs:
2121
uses: devcontainers/ci@v0.3
2222
with:
2323
runCmd: |
24+
set -e
2425
uname -a
2526
lsb_release -a
2627
ruby --version

0 commit comments

Comments
 (0)